Bug#477265: cl-swank: typo in swank-loader.lisp creates spurious warnings

[Dan Torop]

Package: cl-swank
Version: 1:20080223-2
Severity: minor
Tags: patch

In emacs when I start up slime, in the *inferior-lisp* buffer I see:

; loading #P"/usr/share/common-lisp/source/slime/swank-loader.lisp"
; in: LAMBDA NIL
;     (SB-INT:NAMED-LAMBDA SWANK-LOADER::BINARY-PATHNAME
;                        (SWANK-LOADER::SRC-PATHNAME SWANK-LOADER::BINARY-DIR)
;                        (DECLARE (IGNORE SWANK-LOADER::BINARY-DIRECTORY))
;                        (BLOCK SWANK-LOADER::BINARY-PATHNAME
;                          (LET ((SWANK-LOADER::CFP #))
;                            (MERGE-PATHNAMES
;                             (MAKE-PATHNAME :DIRECTORY `# :NAME # :TYPE #)
;                             (COMMON-LISP-CONTROLLER:CALCULATE-FASL-ROOT)))))
; ==>
;   #'(SB-INT:NAMED-LAMBDA SWANK-LOADER::BINARY-PATHNAME
;                          (SWANK-LOADER::SRC-PATHNAME SWANK-LOADER::BINARY-DIR)
;                          (DECLARE (IGNORE SWANK-LOADER::BINARY-DIRECTORY))
;                          (BLOCK SWANK-LOADER::BINARY-PATHNAME
;                            (LET ((SWANK-LOADER::CFP #))
;                              (MERGE-PATHNAMES
;                               (MAKE-PATHNAME :DIRECTORY `# :NAME # :TYPE #)
;                               (COMMON-LISP-CONTROLLER:CALCULATE-FASL-ROOT)))))
; 
; caught STYLE-WARNING:
;   declaring unknown variable BINARY-DIRECTORY to be ignored
; 
; caught STYLE-WARNING:
;   The variable BINARY-DIR is defined but never used.
; 
; compilation unit finished
;   caught 2 STYLE-WARNING conditions

This seems to be due to a typo: the "binary-pathname" function
should ignore "binary-dir", not "binary-directory".

This (minor) problem seems to have entered the package with the commit:
http://git.debian.org/?p=pkg-common-lisp/slime.git;a=commitdiff;h=3b065fc93fd17c37d3d79907c54c91780f93fb74#patch27


-- System Information:
Debian Release: lenny/sid
  APT prefers testing
  APT policy: (990, 'testing'), (800, 'unstable'), (700, 'experimental'), (500, 'stable')
Architecture: i386 (i686)

Kernel: Linux 2.6.24 (PREEMPT)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/bash

Versions of packages cl-swank depends on:
ii  common-lisp-controller        6.12       Common Lisp source and compiler ma

cl-swank recommends no packages.

-- no debconf information
-------------- next part --------------
--- swank-loader.lisp.orig	2008-04-22 01:08:56.000000000 -0400
+++ swank-loader.lisp	2008-04-22 01:09:19.000000000 -0400
@@ -119,7 +119,7 @@
 
 (defun binary-pathname (src-pathname binary-dir)
   "Return the pathname where SRC-PATHNAME's binary should be compiled."
-  (declare (ignore binary-directory))
+  (declare (ignore binary-dir))
   (let ((cfp (compile-file-pathname src-pathname)))
     (merge-pathnames (make-pathname 
                       :directory