Bug#494404: patch + comments on cl-geodesics

[Luca Capello]

tags 494404 + upstream
tags 494404 + fixed
thanks

Hi Peter!

Thank you for your reply and sorry for the lag.

On Tue, 12 Aug 2008 00:36:19 +0200, Peter De Wachter wrote:
> One of the problems is that the ASDF system definition has unbalanced
> parentheses. This makes it impossible to load/use this package.

Already fixed in commit 8e9239ff8ed1a874a399943c28d55aad297d6be4 [1].

> The version in sarge and etch has the same bug, so it doesn't look
> like anybody has used cl-geodesics in the past several years. It
> should probably be removed rather than fixed.

Actually, today cl-geodesics was removed from 'testing' [2].

During DebConf8 I discussed with Luk Claes (part of the Release Team)
about its inclusion in lenny or not.  This doesn't really matter, since
cl-geodesics is in 'contrib', thus it's not part of the official Debian
images.

I'd say that if it compiles, we should keep it, since at least 20 (but
not new) users have it installed [3].  So, again, thank you for the
patch!  Applied: [4] and [5]!

> OTOH, if you decide to keep it, there are a few other problems I
> noticed:
>
> - utilities.lisp doesn't have an IN-PACKAGE form, so it gets loaded in
> whatever random package happens to be active.

Since it's loaded by all the three subsystems, I'd say it's correct.

> - The GD-STATIC-EQUAL, GD-STATIC-UNEQUAL and GD-COSMOLOGICAL
> systems each define the same symbols in the GEODESICS package, so they
> can't be loaded simultaneously. But that's exactly what the GEODESICS
> system does. I think each of the GD-* systems needs to live in a
> separate package?

I guess the idea was to having to load only one system instead of three.
It can also be possible to split geodesics.asd in three different files,
one for each subsystem, still providing the old geodesics.asd which
loads the three.

I haven't uploaded the fixed package yet, I'll wait one more week for
your comments :-)

Thx, bye,
Gismo / Luca

Footnotes: 
[1] http://git.debian.org/?p=pkg-common-lisp/cl-geodesics.git;a=commitdiff;h=8e9239ff8ed1a874a399943c28d55aad297d6be4
[2] http://lists.alioth.debian.org/pipermail/pkg-common-lisp-devel/2008-August/000931.html
[3] http://qa.debian.org/popcon.php?package=cl-geodesics
[4] http://git.debian.org/?p=pkg-common-lisp/cl-geodesics.git;a=commitdiff;h=e085790b18da66d34dce642a86e9c3c35d78093a
[5] http://git.debian.org/?p=pkg-common-lisp/cl-geodesics.git;a=commitdiff;h=15f3f896ca053494898ccc6e818d998ec2aaa7f6
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 314 bytes
Desc: not available
Url : http://lists.alioth.debian.org/pipermail/pkg-common-lisp-devel/attachments/20080826/91fc9b5e/attachment.pgp