[Pkg-corba-devel] filename of omniORB configuration file

[Thomas Girard]

Le lundi 31 mars 2008 à 14:11 +0200, Thomas Girard a écrit :
> > I have doubts on some changes:
> >  * Fix idl/COS/CosTime.idl => depending library should be bumped
>      To see; bumping the shlibs for the library should be enough
>      provided the generated stubs library is not used by any rdep.

Hmm... the change:

  interface TIO {
    boolean spans(...) -> OverlapType spans(...)
    boolean overlaps(...) -> OverlapType overlaps(...)
  }

clearly breaks the API *and* the ABI, as evidenced by the following
program:

  #include <iostream>
  #include <COS/CosTime.hh>

  int main(int argc, char* argv[]) {
        std::cout << "bool: " << sizeof(bool)
                  << std::endl;
        std::cout << "OverlapType: " << sizeof(CosTime::OverlapType)
                  << std::endl;
        return 0;
  }

which outputs on my amd64 box:

  bool: 1
  OverlapType: 4

So the library with the SONAME libCOS4.so.1 breaks binaries using these
symbols with this change. I think we can bump the shlibs only (and
rebuild dependencies) rather than deviate from upstream's SONAME
because:

 1. these symbols were introduced in 4.1.0-1, when fixing #107107, and
    therefore only testing and unstable are affected

 2. there's no Debian package using these symbols

> >  * include/omniORB4/internal/orbParameters.h:
> >    + _CORBA_MODULE_VAR _core_attr CORBA::Boolean immediateRopeSwitch
>      To see. I think it's harmless.

Not a problem. It's only a new symbol, so a shlibs bump is enough.

> >  * include/omniORB4/sslContext.h: in class sslContext
> >    + CORBA::Boolean    pd_ssl_owner; => ABI break; check use.
>      To see. This change really does not look good :-(

I postpone this for tomorrow.

> Also, the license was changed from LGPL 2 to LGPL 2.1.

The COPYING.LIB file was updated but not the headers in the files, so no
problem here.

However, I did not notice that parts of omniORB are GPLv2 while others
are LGPLv2. licensecheck, from devscripts package, told me. We'll need
to fix the copyright file.

Cheers,

Thomas