[Pkg-cups-devel] Bug#347641: logrotate script fails with error when cupsys is not running

[Jim Paris]

Package: cupsys
Version: 1.1.23-15
Severity: normal

The /etc/logrotate.d/cupsys script contains:

  postrotate
          [ -e /var/run/cups/cupsd.pid ] && invoke-rc.d --quiet cupsys restart > /dev/null && sleep 10
  endscript

If /var/run/cups/cupsd.pid does not exist, this line returns an error code, so logrotate says:

  error: error running shared postrotate script for /var/log/cups/*log

I would suggest changing it to:

  postrotate
          if [ -e /var/run/cups/cupsd.pid ] ; then
                  invoke-rc.d --quiet cupsys restart > /dev/null
                  sleep 10
          fi
  endscript

which does not have this problem.

-jim


-- System Information:
Debian Release: testing/unstable
  APT prefers testing
  APT policy: (990, 'testing'), (500, 'unstable')
Architecture: amd64 (x86_64)
Shell:  /bin/sh linked to /bin/bash
Kernel: Linux 2.6.14-2-amd64-k8
Locale: LANG=POSIX, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)

Versions of packages cupsys depends on:
ii  adduser                  3.80            Add and remove users and groups
ii  debconf [debconf-2.0]    1.4.62          Debian configuration management sy
ii  gs-esp                   8.15.1.dfsg.1-1 The Ghostscript PostScript interpr
ii  libc6                    2.3.5-8.1       GNU C Library: Shared libraries an
ii  libcupsimage2            1.1.23-12       Common UNIX Printing System(tm) - 
ii  libcupsys2               1.1.23-12       Common UNIX Printing System(tm) - 
ii  libgnutls12              1.2.9-2         the GNU TLS library - runtime libr
ii  libpam0g                 0.79-3          Pluggable Authentication Modules l
ii  libpaper1                1.1.14-3        Library for handling paper charact
ii  libslp1                  1.2.1-3         OpenSLP libraries
ii  patch                    2.5.9-2         Apply a diff file to an original
ii  perl-modules             5.8.7-9         Core Perl modules
ii  procps                   1:3.2.5-1       /proc file system utilities
ii  xpdf-utils               3.01-3          Portable Document Format (PDF) sui
ii  zlib1g                   1:1.2.3-8       compression library - runtime

Versions of packages cupsys recommends:
ii  cupsys-client                 1.1.23-12  Common UNIX Printing System(tm) - 
pn  foomatic-filters              <none>     (no description available)
ii  smbclient                     3.0.20b-3  a LanManager-like simple client fo

-- debconf information excluded