[Pkg-cups-devel] 58_status_eval_error.dpatch is wrong

[Martin Pitt]

Hi Kenshi,

you recently committed

  * 57_status_logic_error: parallel/usb backends had a logic error around
    verifying printer status code. This patch fixes it. (closes: #347522)

(which is really 58_status_logic_error). I believe this was wrong:

|-    if (!(status & LP_PERRORP))
|+    if (status & LP_PERRORP)
|       fputs("WARNING: Printer fault!\n", stderr);
|-    else if (!(status & LP_PSELECD))
|+    else if (status & LP_PSELECD)
|       fputs("WARNING: Printer off-line.\n", stderr);

According to /usr/include/linux/lp.h, LP_PSELECD is active high, i. e.
if the bit is cleared, the printer is off-line and the original code
is correct. Likewise, LP_PERRORP is active-low, i. e. if the bit is
set, there is *no* error.

The reported bugs are really about certain printer models which do not
adhere to the parallel port specification. This didn't matter in cups
1.1 since it didn't do these tests at all.

So, this should be reverted for now until upstream finds a workaround.

Thank you!

Martin

-- 
Martin Pitt        http://www.piware.de
Ubuntu Developer   http://www.ubuntu.com
Debian Developer   http://www.debian.org

In a world without walls and fences, who needs Windows and Gates?
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
Url : http://lists.alioth.debian.org/pipermail/pkg-cups-devel/attachments/20060710/fe77577c/attachment.pgp