[Pkg-cups-devel] Bug#660631: cups-client: Endless loop in cupsaddsmb if used with '-a' switch

[Christian Andretzky]

Package: cups-client
Version: 1.4.4-7+squeeze1
Severity: normal
Tags: squeeze patch

The subject says all. If I try to export all cups printers to samba, cupsaddsmb seems to hang.
Testing this with the -v switch I could see that cupsaddsmb is in an endless loop because at least
one of the operations (As far as I remember correctly - can not check this in the moment) could not
be completed.

Starting without the '-a' switch for each printer separately works for me.

The following wrapper script solves the problem for me:

--------------------8<-------------------------
#!/bin/bash

#set -x
set -u

CupsAddSMB=$( which cupsaddsmb )

# no more changes below this line

AskUserData()
        {
        read -p "Please enter username for acessing cupsaddsmb [default: ${USER}]: " UserName
        if [ -z "${UserName}" ]; then
                UserName=${USER}
        fi
        read -s -e -p "Please enter password for user ${UserName} to access cupsaddsmb: " Passwd
        echo ""
        }

if [ -n "${CupsAddSMB}" ]; then
        CupsPrinters=( $( lpstat -a | awk '{ print $1 }' | sort -u ) )
        if [ ${#CupsPrinters[*]} -gt 0 ]; then
                AskUserData
                for CupsPrinter in ${CupsPrinters[*]}; do
                        ${CupsAddSMB} -U ${UserName}%${Passwd} ${CupsPrinter}
                done
        else
                echo "FATAL: no printers defined in cups, aborted."
                exit -1
        fi
else
        echo "FATAL: cupsaddsmb not found, aborted."
        exit -1
fi
--------------------8<-------------------------

Cheers, Christian


-- System Information:
Debian Release: 6.0.4
  APT prefers stable
  APT policy: (990, 'stable'), (500, 'stable-updates'), (500, 'testing')
Architecture: amd64 (x86_64)

Kernel: Linux 2.6.32-5-amd64 (SMP w/6 CPU cores)
Locale: LANG=de_DE.UTF-8, LC_CTYPE=de_DE.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

Versions of packages cups-client depends on:
ii  adduser                 3.112+nmu2       add and remove users and groups
ii  cups-common             1.4.4-7+squeeze1 Common UNIX Printing System(tm) - 
ii  libc6                   2.11.3-2         Embedded GNU C Library: Shared lib
ii  libcups2                1.4.4-7+squeeze1 Common UNIX Printing System(tm) - 
ii  libcupsimage2           1.4.4-7+squeeze1 Common UNIX Printing System(tm) - 
ii  zlib1g                  1:1.2.3.4.dfsg-3 compression library - runtime

cups-client recommends no packages.

Versions of packages cups-client suggests:
ii  cups                    1.4.4-7+squeeze1 Common UNIX Printing System(tm) - 
ii  cups-bsd                1.4.4-7+squeeze1 Common UNIX Printing System(tm) - 
pn  cups-pt                 <none>           (no description available)
pn  gtklp                   <none>           (no description available)
pn  kdeprint                <none>           (no description available)
pn  xpp                     <none>           (no description available)

-- no debconf information