[Pkg-cups-devel] Bug#663070: cups-filters: Please complete the implementation of fontconfig-based font selection

[Fabian Greffrath]

Package: cups-filters
Version: 1.0.4-1
Severity: normal
Tags: patch upstream

Hi,

I have decided to open a new bug to complete the switch to font selection based
on fontconfig patterns instead of file names. The attached patch applies to the
current cups-filters 1.0.4 release and *replaces all the patches I have
previously sent* to the now closed #662660.

It also fixes some Errata in my previous patches from #662660, namely:
- In filter/pdf.utf-8.heavy I replaced the font file name "COUR.TTF" (and its
variants) with the fontconfig pattern "Courier", whereas the file actually
contains the "CourierNew" font.
- In filter/texttopdf.c the line "#include <string.h>" isn't needed anymore,
since we are not handling file names anymore and thus do not need to remove
file name extensions.
- The "int index" variable is not needed actually. The FcPatternFormat()
function knows the "%{index}" part of its format string on its own.
- The indentation of the new code was still 4 blanks, as if it was still inside
the "if (!otf)" condition, which got removed.

So, please, forget about the patches I sent to #662660, apply only this one and
the transition to font selection based on fontconfig patterns instead of file
names in clean and complete. In its current state, i.e. as released with 1.0.4
it is a mixture of both and none of both done right. ;)

Cheers,
Fabian


-- System Information:
Debian Release: wheezy/sid
  APT prefers testing
  APT policy: (901, 'testing'), (501, 'unstable'), (101, 'experimental')
Architecture: i386 (i686)

Kernel: Linux 3.1.0-1-686-pae (SMP w/1 CPU core)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: fontconfig-patterns.patch
Type: text/x-diff
Size: 6097 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/pkg-cups-devel/attachments/20120308/9908f879/attachment.patch>