[Pkg-cups-devel] Bug#663564: cups-filters: 'make clean' leaves some object files over

[Fabian Greffrath]

Package: cups-filters
Version: 1.0.4-1
Severity: normal
Tags: patch upstream

Hi,

currently, 'make clean' -- if run from the top-level source directory -- does
not entirely clean the source tree but leaves some object files in the
filter/fontembed and pdftoopvp/oprs sub-directories around. This is especially
frustrating if you are trying to build the Debian package twice in a row, as
dpkg-source will complain about untrackable differences in the source tree. The
attached patch adds calls to the clean rules in these sub-directories to the
Makefiles in the containing directories.

Furthermore, the Makedefs file is on the one hand removed in the distclean rule
but on the other hand unconditionally included in all the Makefiles. This makes
it imposible to e.g. run the clean rule twice in a row. I have therefore
included a conditional to only include Makedefs if Make is *not* run for any of
the clean rules. Since each Makefile in the sub-directories also includes
Makedefs, I decided to merely touch it in the clean rule of the top-level
Makefile. So 'make clean' is at least idempotent if run from the top-level
Makefile.

 - Fabian



-- System Information:
Debian Release: wheezy/sid
  APT prefers testing
  APT policy: (901, 'testing'), (501, 'unstable'), (101, 'experimental')
Architecture: i386 (i686)

Kernel: Linux 3.2.0-1-686-pae (SMP w/1 CPU core)
Locale: LANG=de_DE.utf8, LC_CTYPE=de_DE.utf8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
-------------- next part --------------
A non-text attachment was scrubbed...
Name: make-clean.patch
Type: text/x-diff
Size: 837 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/pkg-cups-devel/attachments/20120312/2b932d8d/attachment.patch>