Bug#402814: cyrus-imapd-2.2: Inadequate documentation of 'sasl_minimum_layer'

[Michael Richters]

On Wed, Dec 13, 2006 at 11:51:02PM -0200, Henrique de Moraes Holschuh wrote:
> On Wed, 13 Dec 2006, Michael Richters wrote:
> > FYI: the string "sasl_minimum_layer" appears in the cyrus-imapd-2.2
> > source package, but not in the cyrus-sasl2 package:
> 
> Strip the sasl_ prefix when grepping SASL code and docs.

I did.  Take a look at the arguments to 'grep' in my previous message.

> > I don't think it's reasonable to expect someone to grep through the
> > source in order to determine that "sasl_minimum_layer" in one package
> > translates to "min_ssf" in another.  Not to mention the fact that this
> > information still doesn't lead me to an answer to my original
> > question.
> 
> It should not translate to min_ssf at all, unless SASL is renaming options,
> in which case whomever is doing the translation needs to document it (either
> cyrus imap or sasl).

Unless I'm reading this wrong, cyrus-imapd is responsible for the
translation.  Mind you, I haven't taken the time to really read and
understand the code from which this is excerpted.

cyrus-imapd-2.2-2.2.13/lib/imapopts.c:162:  { IMAPOPT_SASL_MINIMUM_LAYER, "sasl_minimum_layer", 0, {(void*)0}, OPT_INT, {  { NULL, IMAP_ENUM_ZERO } } },
cyrus-imapd-2.2-2.2.13/imap/global.c:297:    ret.min_ssf = config_getint(IMAPOPT_SASL_MINIMUM_LAYER);


  --Mike