10-fix_potential_overflows.dpatch

[Ondřej Surý]

I tend to agree with you. It's not wrong per se, but it's useless,
since len+1 char will be always overwritten by '\r'. And if hdr is
0-terminated string there will be always \0 at len+1 char.

Ondrej

On Fri, Jul 9, 2010 at 22:58, Patrick Goetz <pgoetz at mail.utexas.edu> wrote:
> Can someone, maybe Sven, take a look at this patch?  This can't possibly be
> right:
>
> --- git~/imap/message.c 2010-01-16 19:22:57.000000000 -0200
> +++ git/imap/message.c  2010-01-16 19:27:30.915091898 -0200
> @@ -996,7 +996,7 @@
>     /* Save header value */
>     len = hdrend - hdr;
>     message_ibuf_ensure(ibuf, len+2);
> -    strncpy(ibuf->end, hdr, len);
> +    strncpy(ibuf->end, hdr, len+1);
>     ibuf->end += len;
>     *(ibuf->end)++ = '\r';
>     *(ibuf->end)++ = '\n';
>
>
> _______________________________________________
> Pkg-Cyrus-imapd-Debian-devel mailing list
> Pkg-Cyrus-imapd-Debian-devel at lists.alioth.debian.org
> http://lists.alioth.debian.org/mailman/listinfo/pkg-cyrus-imapd-debian-devel
>



-- 
Ondřej Surý <ondrej at sury.org>
http://blog.rfc1925.org/