master process handling patch

[Ondřej Surý]

On Wed, Jul 21, 2010 at 21:56, Patrick Goetz <pgoetz at mail.utexas.edu> wrote:
> argh, I sent this message to the wrong list again!
>
> On 07/15/2010 05:23 PM, Henrique de Moraes Holschuh wrote:
>>
>> Heh, you can already use whatever we have in the experimental branch, it
>> is
>> good enough for limited use :)
>>
>
> This isn't entirely true.  This patch, which I mentioned previously,
> looks like it could lead to header corruption in the saved header stored
> in ibuf:

How? I think we already cleared that this patch doesn't do any good or
any harm on any debian platform.

> -------------------------------------------
> 10-fix_potential_overflows.dpatch:
> --- git~/imap/message.c 2010-01-16 19:22:57.000000000 -0200
> +++ git/imap/message.c  2010-01-16 19:27:30.915091898 -0200
> @@ -996,7 +996,7 @@
>     /* Save header value */
>     len = hdrend - hdr;
>     message_ibuf_ensure(ibuf, len+2);
> -    strncpy(ibuf->end, hdr, len);
> +    strncpy(ibuf->end, hdr, len+1);
>     ibuf->end += len;
>     *(ibuf->end)++ = '\r';
>     *(ibuf->end)++ = '\n';
> ------------------------------------------

Ondrej
-- 
Ondřej Surý <ondrej at sury.org>