Cyrus IMAPD 2.4: Release early, release often

[Henrique de Moraes Holschuh]

On Mon, 22 Nov 2010, Anthony Prades wrote:
> >init.d script check this file but for some reason PACKAGE_VERSION is null
> >and cyrus not start. commenting out
> >
> >grep -qE '^PACKAGE_VERSION[[:blank:]]+([0-9]+:|)2[.]3' \
> >       /usr/lib/cyrus/cyrus-hardwired-config.txt >/dev/null 2>&1 || exit 0

If PACKAGE_VERSION is missing, that's the bug that needs fixing.

If we can *always* upgrade from 2.3 to 2.4 without the need for local
admin checks, we should update the grep to allow for that (but *only* in
that case).  The same goes to 2.2.

It does NOT apply to 2.1, as local admin actions are *required* for the
upgrade (run massivec at the very least).

> --- a/debian/cyrus-common-2.4.cyrus-imapd.init
> +++ b/debian/cyrus-common-2.4.cyrus-imapd.init
> @@ -46,7 +46,7 @@ DESC="Cyrus IMAPd"
>  
>  # Check if Cyrus is installed
>  test -x ${DAEMON} || exit 0
> -grep -qE '^PACKAGE_VERSION[[:blank:]]+([0-9]+:|)2[.]3' \
> +grep -qE '^PACKAGE_VERSION[[:blank:]]+([0-9]+:|)2[.]4' \
>  	/usr/lib/cyrus/cyrus-hardwired-config.txt >/dev/null 2>&1 || exit 0
>  
>  set -e
> diff --git a/debian/rules b/debian/rules
> index 4dd25a6..c4289c3 100755
> --- a/debian/rules
> +++ b/debian/rules
> @@ -24,6 +24,9 @@ export DOCDIR := $(CURDIR)/debian/$(DOCPKG)/usr/share/doc/$(DOCPKG)
>  DEB_HOST_GNU_TYPE  ?= $(shell dpkg-architecture -qDEB_HOST_GNU_TYPE)
>  DEB_BUILD_GNU_TYPE ?= $(shell dpkg-architecture -qDEB_BUILD_GNU_TYPE)
>  
> +# Extra version information to add to Cyrus IMAPd ID
> +DEBVERSION ?= $(shell LCALL=C dpkg-parsechangelog | sed -ne 's/^Version: \(.*-\)/\1/p')
> +
>  # DB engine version
>  export BDB_VERSION ?= $(shell LC_ALL=C dpkg-query -l 'libdb4.[2-8]-dev' | grep ^ii | sed -e 's|.*\s\libdb\(4\.[0-9]\)-dev\s.*|\1|')
>  DBENGINE := BerkeleyDB$(BDB_VERSION)

Acked-by: Henrique de Moraes Holschuh <hmh at debian.org>

But if we find out that we can always let 2.3->2.4 happen automatically,
the grep should be extended to allow that.

-- 
  "One disk to rule them all, One disk to find them. One disk to bring
  them all and in the darkness grind them. In the Land of Redmond
  where the shadows lie." -- The Silicon Valley Tarot
  Henrique Holschuh