Bug#658915: upgrade-db prematurely deletes $CONFIG_DIR/db

[Andres Freund]

Package: cyrus-common
Version: 2.4.13-1

While upgrading a cyrus environment from 2.2 (manually upgraded package built 
ages ago) I found upgrade-db failing in the midst of the upgrade. Looking at 
the script the issue seems to be that it removes $CONFIG_DIR/db when finding 
any non-bdb backed database which then will cause it failing for further bdb 
databases. Removing the deletion of that dir fixes the issue for me.

The solution seems to be to move the removal of the directory outside the loop 
in upgradealldb which iterates over the individual databases. Am I missing 
something?

Andres

PS: I hit this issue in a backported (to squeeze) version but I doubt that 
actually changes anything...