Contributing improvements (2.5.11, bug fixes)

[Boris Dušek]

Hello,

I would like to contribute some improvements to the cyrus-imapd source package. I have a git repository at github.com/dusek/pkg-cyrus-imapd where in branch "fixes-2.5.11", I fix 2 bugs by patches, and then 3 bugs by upgrading to 2.5.11 (including refreshing of patches, and including having at the said repository the corresponding “upstream" and "pristine-tar" branches):

– #872247: broken symlinks (~sieve) (patch) ( https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=872247 )
– #883951: libical3 build failure (patch) ( https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=883951 )
– #863520: Fatal error with SSL (2.5.11 update) ( https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=863520 )
– #879007: not accepting new connections (2.5.11 update) ( https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=879007 )
– #878842: process bomb with Apple Mail (2.5.11 update) ( https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=878842 )

Except for the broken symlinks issue, which I fixed myself, in the remaining cases I used the information about upstream patches that was present Debian bug discussion for the given issue.

I would like to request some feedback on the changes, with the hope of working towards reaching a state where the maintainers would be happy to consider this for inclusion. I am not that experienced in Debian packages (and packaging now for the first time after ~6 years when I did so for the first time), so apologies in advance if I miss some obvious things.

E.g. I would be happy to rework the upgrade to 2.5.11 to instead stay on 2.5.10 but fix the 3 bugs by explicitly applying patches from upstream which were kindly linked by bug report participants (maybe that would make it easier to then make an update to stable for some of the issues?), but my thinking was that since 2.5.11 is I presume in bug fix mode, it is more appropriate to use the whole newer bugfix patch release instead of hand-picking patches. Also I would be happy to rework the broken symlink bug by linking /usr/bin/sieveshell to /usr/lib/cyrus/bin/sieveshell (and similarly for installsieve) instead of adding a dependency of cyrus-admin on cyrus-common. Also I do not know if some of the stuff in the release notes [1] (and in particular the change to “timeout”, which fixes one of the above issues) warrant some message during upgrade. I would also be happy to move my changes into more appropriate location (e.g. a merge request against a new salsa.debian.org repo for this purpose, as indicated at [2]) if that would make it easier for the maintainers.

I tested the packages by simply running `gbp buildpackage -us -uc` inside a docker container with Debian unstable, after installing the build dependencies with `mk-build-deps` and adding an empty changelog item for 2.5.11 (which is not in git since I presume the changelog entry should be added (e.g. by `gb dch`) and finalized by the maintainer right before deciding to make an upload). Further specifically for the cyrus-admin issue, I simply tested that the sieveshell command returns its help (i.e. runs), by installing `dpkg -i cyrus-admin*.deb cyrus-common*.deb` followed by `apt-get -f install`. I also wanted to test the .tar.gz.sig signature, but was unsuccessful at importing the right gpg key, so I raised cyrus-imapd#2306 [3] to ask for where to find the key for the signature of tarball I used for manually doing `gbp import-orig`.

Thanks & kind regards,
Boris

[1]: Cyrus IMAP 2.5.11 Release Notes: https://www.cyrusimap.org/2.5/imap/release-notes/2.5/x/2.5.11.html
[2]: http://lists.alioth.debian.org/pipermail/pkg-cyrus-imapd-debian-devel/2018-January/004985.html
[3]: https://github.com/cyrusimap/cyrus-imapd/issues/2306