[Pkg-d-devel] dsss and libtango packages

[Vincenzo Ampolo]

oh!

Finally a good review to work with

Thanks a lot! :D

On Tuesday 14 October 2008 00:06:57 Peter De Wachter wrote:
> - Your diff adds a rebuild/dsss.last file. I guess this is something
> generated during the build, if so you should delete it in your clean
> target so that it doesn't end up in your diff.

Right

>
> - lintian -Ii gives a couple of warnings. Mostly about manpages.

Yep... i guess i should write a manpage for both drebuild_choosedc and drerun

>
> - The usr/bin/rerun symlink should point to drebuild instead of
> rebuild. And it should probably be called drerun. Is it even needed at
> all? It seems rather useless.

I talked with Gregor Richards, it's needed to run the D interpreter... i'm 
going to call it drerun and patch drebuild to be able to recognize it.

>
> - You should include the upstream changelog and documentation. Just put
> the name of the changelog after the dh_installchangelogs command, and
> list the file names of the useful documentation in dsss.docs.

Ok.

>
> - It looks like the upstream source comes with a test suite, you should
> run that during the build, if you don't already do that.

I didn't check it. i'll do.

>
> - The /usr/include files should be put in a separate -dev package. (I
> assume they're not needed for ordinary dsss usage.)

Right. i'll create dsss-dev (according to Gregor Richards)

>
> - /usr/lib/dymoduleinit.d is weird. What is it, why does it go
> into /usr/lib? That's almost certainly wrong. Dumping random files
> in /usr/lib is not OK.

I'll remove it... it's a under development feature to build d modules 
automatically when they are needed.

>
> > As expected gdc on intrepid is messed up, i filled a LP bug #282400 .
> > It works/compiles like a sharm on ubuntu 8.04.
>
> Odd, gdc-4.2 works on Debian.

Also in amd64?
it work in 386 too here :D

> His intentions are good, but his legalise is poor :) And for
> distributors it's very important that all the legalise is clear and
> unambiguous.
>
> The basic problem is that Walter specified version 1 of the GPL, but
> didn't make clear that upgrading to newer versions is permitted. And in
> copyright law, if something isn't explicitly permitted by the copyright
> holder, it is not allowed. So integrating that code into gcc
> (GPLv2-or-higher) was not technically legal.
>
> Though it looks like this doesn't really matter for dsss, as I can't
> find any GPLv2-or-higher licensed code.

Ok. I'll talk with Walter Bright about this issue too :D

> These two emails explain how to write proper copyright files:
> http://lists.debian.org/debian-devel-announce/2003/12/msg00007.html
> http://lists.debian.org/debian-devel-announce/2006/03/msg00023.html

Good that's what i needed.

> It looks like you can just override CXXFLAGS on the drebuild make
> command line:
> cd rebuild && $(MAKE) CXXFLAGS="$(CXXFLAGS)"
> (I think cdbs initializes CXXFLAGS to a sensible default)

Ok.

I'm doing all the changes, soon i'll ask another review :D

Sorry for pestering you.

-- 
Vincenzo Ampolo
http://vincenzo-ampolo.net
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part.
Url : http://lists.alioth.debian.org/pipermail/pkg-d-devel/attachments/20081014/f2405609/attachment.pgp