[pkg-dhcp-devel] Bug#616290: [Fwd: [ISC-Bugs #25979] What happened to the dhcp patch in ISC-Bugs #24697 (Debian Bug #616290)?]

[Ian Jackson]

Svante Signell writes ("Re: [Fwd: [ISC-Bugs #25979] What happened to the dhcp patch in ISC-Bugs #24697 (Debian Bug #616290)?]"):
> On Thu, 2011-12-15 at 14:15 +0000, Ian Jackson wrote:
> > Where can I find the detailed explanation of why this patch is
> > required and how it works to fix the problems ?  At the moment I can't
> > even seem to find an error message from an FTBFS log.

This was really my key question.

Any submission of a patch allegedly fixing a bug (by which I mean to
include a portability problem), to any project, should include a clear
description, in detail, of what the bug is thought to be and how the
patch solves it.

> More information can be found at the debian-hurd and bug-hurd ML
> archives:
> 
> http://lists.gnu.org/archive/html/bug-hurd/2011-02/threads.html
> http://lists.gnu.org/archive/html/bug-hurd/2011-03/threads.html

A reference to a mailing list thread may helpful as background
reading, but I'm afraid it does not meet the standard I would expect
for a patch submission.

I'm afraid you need to go back and revise your submissions to isc-dhcp
upstream.  You need to:

 * Identify what the separate problems are

 * For each individual problem:
   - Research applicable best practices and standards
   - Decide accordingly whether the fault lies with isc-dhcp or hurd
   - Decide how to fix the problem
   - Create and test a separate patch, either against isc-dhcpd or
     hurd or perhaps both
   - Write a clear and detailed explanation; this explanation 
     should cover all of the matters I've just mentioned.

So far our (Debian's) communications with dhcpd upstream on this topic
seem to be lacking in this area.  If you like I would be happy to
review your next submissiosn to upstream, before you send them.

Thanks,
Ian.