[pkg-dhcp-devel] Bug#592539: Improved patch

[Steven Ihde]

Hi,

Using the patch from Gemes Geza as a starting point:

http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=592539#49

I've reworked the patch, tested it, run it on my own host for several weeks, and rebased against the latest release (4.2.4-7).

I tested that upgrading from an existing install works (and preserves the existing $INTERFACES setting), tested clean install and made sure the debconf interface works, and verified the v6 daemon responds to requests.

The updated patch (generated with debdiff) is attached.

The following points are worth mentioning:

* left the INTERFACES variable (and interfaces) debconf value with their existing names, to improve compatibility with the upgrade path
* fixed the init.d script such that multiple interfaces are handled correctly
* reworked the init.d script such that both v4 and v6 configs are tested before starting or restarting either daemon
* removed the dhclient6 stuff from Gemes' patch; happy to send an updated diff that includes this but it seemed simpler is better for now so I've only addressed dhcpd
* the convention around "true" vs "yes" for values in /etc/default is not clear to me; it seems debconf always goes with true/false for a boolean, but many other scripts in /etc/default seem to use "yes".  I just used "true".
* Three new debconf values are added, with accompanying documentation; this impacts the translations

I welcome any feedback on how to improve the patch or get it applied.  Happy to send a pull request as well as I've cloned the isc-dhcp git repo.

Thanks,

Steve

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.alioth.debian.org/pipermail/pkg-dhcp-devel/attachments/20140117/d2fc57cd/attachment-0002.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: isc-dhcp-server-ipv6.patch
Type: application/octet-stream
Size: 128492 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/pkg-dhcp-devel/attachments/20140117/d2fc57cd/attachment-0001.obj>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.alioth.debian.org/pipermail/pkg-dhcp-devel/attachments/20140117/d2fc57cd/attachment-0003.html>