[Pkg-dkms-maint] Bug#586725: dkms attempts to install modules in wrong order

[Jan Muszynski]

Package: dkms
Version: 2.1.1.2-3
Severity: normal
Tags: patch

This shows up, on my system, when trying to build the modules for virtualbox (PUEL). There are 3 modules, and they need to be built in a specific order (the others depend on the first to build correctly). If dkms processes the modules in sorted sequence everything is fine. Otherwise I have to manually get the modules to build. Here's an example of what I mean:

'find "$dkms_tree" -maxdepth 1 -mindepth 1 -type d' returns, on my system:
/var/lib/dkms/vboxnetadp
/var/lib/dkms/vboxnetflt
/var/lib/dkms/nvidia
/var/lib/dkms/vboxdrv

The 2 vboxnet modules dpend on the vboxdrv module in order to compile correctly, so this ends up failing. After patching the autoinstaller to pipe the results through a sort the order becomes:
/var/lib/dkms/nvidia
/var/lib/dkms/vboxdrv
/var/lib/dkms/vboxnetadp
/var/lib/dkms/vboxnetflt

And this works just fine. Patch attached. Need anything else please let me know.
TIA
-jcm

-- System Information:
Debian Release: squeeze/sid
  APT prefers testing
  APT policy: (900, 'testing'), (100, 'unstable'), (1, 'experimental')
Architecture: i386 (i686)

Kernel: Linux 2.6.34-02.i386vanilla (PREEMPT)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

Versions of packages dkms depends on:
ii  build-essential              11.5        Informational list of build-essent
ii  dpkg-dev                     1.15.7.2    Debian package development tools
ii  gcc                          4:4.4.4-2   The GNU C compiler
ii  make                         3.81-8      An utility for Directing compilati
ii  module-init-tools            3.12~pre2-3 tools for managing Linux kernel mo

Versions of packages dkms recommends:
ii  fakeroot                    1.14.4-1     Gives a fake root environment
ii  linux-headers-2.6.32-5-686  2.6.32-15    Header files for Linux 2.6.32-5-68
ii  linux-headers-2.6.34-0.dmz. 2.6.34-43    Header files for Linux 2.6.34-0.dm
ii  linux-headers-2.6.34-02.i38 2010.163.jcm Header files related to Linux kern
ii  linux-image-2.6.32-5-686 [l 2.6.32-15    Linux 2.6.32 for modern PCs
ii  linux-image-2.6.34-0.dmz.12 2.6.34-43    Linux 2.6.34 for modern PCs
ii  linux-image-2.6.34-02.i386v 2010.163.jcm Linux kernel binary image for vers
ii  lsb-release                 3.2-23.1     Linux Standard Base version report
ii  menu                        2.1.43       generates programs menu for all me
ii  patch                       2.6-2        Apply a diff file to an original
ii  sudo                        1.7.2p7-1    Provide limited super user privile

dkms suggests no packages.

-- Configuration Files:
/etc/kernel/prerm.d/dkms changed [not included]

-- no debconf information
-------------- next part --------------
--- /usr/lib/dkms/dkms_autoinstaller.old	2010-06-15 09:37:18.947762234 -0400
+++ /usr/lib/dkms/dkms_autoinstaller	2010-06-15 09:38:40.173964008 -0400
@@ -71,7 +71,7 @@
     fi
 
     # Iterate over the modules
-    for modulepath in $(find "$dkms_tree" -maxdepth 1 -mindepth 1 -type d); do
+    for modulepath in $(find "$dkms_tree" -maxdepth 1 -mindepth 1 -type d|sort); do
 
         module_in_tree=${modulepath##*/}
         # Determine which versions to show status for