[Pkg-dns-devel] Bug#862757: Should be ported from libnm-glib/libnm-util to libnm

[Michael Biebl]

Package: dnssec-trigger
Version: 0.13-6
Severity: normal
Tags: patch
User: pkg-utopia-maintainers at lists.alioth.debian.org
Usertags: libnm


Hi,

libnm-glib/libnm-util has been deprecated upstream in favour of libnm.

Your package seems to use the GIR bindings for those libraries.

The libnm based GIR bindings have been split off into a separate package
called gir1.2-nm-1.0 and it is currently available in experimental.
As soon as buster opens for development, this will be uploaded to
unstable.

Please port dnssec-trigger to use the new libnm based bindings. The API
for libnm [1] is in most cases identical to the one provided by
libnm-glib/libnm-util.

The attached patch should do the trick. It's untested though, so please
review  and test carefully and ideally forward to upstream.


Would be great if you can prepare those changes in experimental or make
them early in the buster release cycle.

Regards,
Michael

[1] https://developer.gnome.org/libnm/stable/

P.S: While looking at dnssec-trigger-script.in, I noticed that you parse
/etc/NetworkManager/NetworkManager.conf directly. Be aware that NM
supports conf snippets in /etc/NetworkManager/conf.d/ and
/usr/lib/NetworkManager/conf.d/, so parsing NetworkManager.conf alone is
insufficient.

-- System Information:
Debian Release: 9.0
  APT prefers unstable
  APT policy: (500, 'unstable'), (200, 'experimental')
Architecture: amd64
 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.9.0-3-amd64 (SMP w/4 CPU cores)
Locale: LANG=de_DE.utf8, LC_CTYPE=de_DE.utf8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
-------------- next part --------------
diff --git a/debian/control b/debian/control
index c51a4ee..95e1dee 100644
--- a/debian/control
+++ b/debian/control
@@ -26,7 +26,7 @@ Depends: ${shlibs:Depends},
 	 python,
 	 python-gi,
 	 python-lockfile,
-	 gir1.2-networkmanager-1.0 (>= 1.1.90) [linux-any],
+	 gir1.2-nm-1.0 (>= 1.2) [linux-any],
 	 unbound
 Breaks: resolvconf
 Description: reconfiguration tool to make DNSSEC work
diff --git a/dnssec-trigger-script.in b/dnssec-trigger-script.in
index 154f124..1d74710 100644
--- a/dnssec-trigger-script.in
+++ b/dnssec-trigger-script.in
@@ -18,7 +18,7 @@ import struct
 import signal
 
 import gi
-gi.require_version('NMClient', '1.0')
+gi.require_version('NM', '1.2')
 
 from gi.repository import NMClient
 
@@ -466,7 +466,7 @@ class Application:
         except AttributeError:
             self.usage()
 
-        self.client = NMClient.Client().new()
+        self.client = NM.Client().new()
 
     def nm_handles_resolv_conf(self):
         if not self.client.get_manager_running():