[Pkg-dspam-misc] dspam 3.9 database upgrade : fix for the postgesql backend.

[Julien Valroff]

Le jeudi 01 avril 2010 à 20:15 +0200, Philippe Le Brouster a écrit :
> Hi,
> 
> Le Thursday 1 April 2010 à 19:07 +0200, Julien Valroff a écrit:
> > The only thing I can see in the UPGRADING file is the following
> > statement:
> > 2. Ensure PosgreSQL is using the new database schema. The following clauses should
> >    be executed for upgrading pre-3.9.0 DSPAM PosgreSQL schema to the 3.9.0 schema:
> >      ALTER TABLE dspam_preferences ALTER COLUMN uid TYPE integer;
> >      ALTER TABLE dspam_signature_data ALTER COLUMN uid TYPE integer;
> >      ALTER TABLE dspam_stats ALTER COLUMN uid TYPE integer;
> >      ALTER TABLE dspam_token_data ALTER COLUMN uid TYPE integer;
> >      DROP INDEX IF EXISTS id_token_data_sumhits;
> > 
> >    If you are using virtual users in DSPAM, then you should execute the following
> >    clause for upgrading pre-3.9.0 DSPAM virtual uids to the 3.9.0 schema:
> >      ALTER TABLE dspam_virtual_uids ALTER COLUMN uid TYPE integer;
> > 
> > It is already present in debian/sqlfiles/upgrade/pgsql/3.8
> > This file should actually be renamed to 3.9 - I had added it before the
> > official 3.9.0 release - but this should not cause any issue anyway, as
> > the dbconfig-commong documentation states:
> > "when a package upgrade occurs, all instances of VERSION which are newer
> > than the previously installed version will be applied, in order"
> > 
> > Would you please explain what your patch makes, and where have you seen
> > that it is necessary to be run?
> > Sorry if that might seem idiot questions, but I must say I haven't
> > worked on this for a quite long time now, and I am not a pgsql person ;)
> 
> It seems that the UPGRADING file is not up to date because it didn't
> mention the update from 3.8 to 3.9.

Have you reported this upstream as this might mislead a lot of people,
especially as the comments say "upgrading pre-3.9.0 DSPAM virtual uids
to the 3.9.0 schema".

> In the dspam repository, the
> postgresql scheme between 3.8 and 3.9 has changed. You can check this
> with :
> 
>   $ git clone git://dspam.git.sourceforge.net/gitroot/dspam/dspam
>   $ cd dspam
>   $ git diff origin/RELENG_3_8 origin/RELENG_3_9  src/tools.pgsql_drv/pgsql_objects.sql
>     (diff output attached)

Well, I will have to check this for other backends as well...

I will work on this during the week-end and update the unofficial
packages.
Thanks for your help.

> > I also take the leave to re-raise a ***CALL FOR HELP*** as it seems I am
> > the only one to work on trying to get DSPAM packages for Debian, but I
> > do not have all the required skills to achieve this alone.
> 
> What is needed to be done before uploading dspam 3.9 in the debian
> archive ?

Well, I guess more testing, a full check of the changes I have made, and
again some more testing.
It also lacks of manpower to maintain the packages actively. The
pkg-dspam team members unfortunately seem to not be interested in DSPAM
anymore, and it is now very likely DSPAM won't be part of the upcoming
Squeeze release, which is a real pitty.

My fear is that people will use "my" unofficial packages as a
workaround, and I do not feel very comfortable with this.

I think the packages are in a quite good state right now, with only
"minor" issues (and a lot of possible improvements of course). If at
least one or two skilled people could commit in co-maintaing the
packages, I think it could be uploaded to experimental at least.

Cheers,
Julien