[Evolution] Bug#365294: gtkhtml3.8: implicit pointer conversion

[dann frazier]

tag 365294 + patch
stop

On Mon, May 01, 2006 at 12:05:38PM -0600, dann frazier wrote:
> On Mon, May 01, 2006 at 02:13:48PM +0200, Heikki Henriksen wrote:
> > fre, 28,.04.2006 kl. 19.16 -0600, skrev dann frazier:
> > > Our automated buildd log filter[1] detected a problem that will cause
> > > your package to segfault on architectures where the size of a pointer
> > > is greater than the size of an integer, such as ia64 and amd64.
> > > [1]http://people.debian.org/~dannf/check-implicit-pointer-functions
> > 
> > Hiya Dann.
> > 
> > Thanks for checking this. I've tested your patch against current
> > (recently uploaded to unstable ) gtkhtml3.8 (3.10.1), but still get the
> > same error from the checking script. Do you think it will still
> > segfault, or will the #include "gtkhtml-private.h" circumvent that
> > segfault?
> 
> I'm getting the same results that you are.  My patch is therefore
> incorrect; sorry about that.

Correction - my patch does still appear correct:

dannf at krebs:/space/debian$ apt-get source gtkhtml3.8
Reading package lists... Done
Building dependency tree... Done
Need to get 1853kB of source archives.
Get:1 http://debian-mirror.fc.hp.com unstable/main gtkhtml3.8 3.10.1-1 (dsc) [957B]
Get:2 http://debian-mirror.fc.hp.com unstable/main gtkhtml3.8 3.10.1-1 (tar) [1844kB]
Get:3 http://debian-mirror.fc.hp.com unstable/main gtkhtml3.8 3.10.1-1 (diff) [7789B]
Fetched 1853kB in 0s (2800kB/s)
gpg: Signature made Fri Apr 28 14:07:48 2006 MDT using DSA key ID 917A225E
gpg: Can't check signature: public key not found
dpkg-source: extracting gtkhtml3.8 in gtkhtml3.8-3.10.1
dpkg-source: unpacking gtkhtml3.8_3.10.1.orig.tar.gz
dpkg-source: applying ./gtkhtml3.8_3.10.1-1.diff.gz
dannf at krebs:/space/debian$ cd gtkhtml3.8-3.10.1/
dannf at krebs:/space/debian/gtkhtml3.8-3.10.1$ fakeroot ./debian/rules build 2>&1 | ~/bin/check-implicit-pointer-functions
Function `gtk_html_filename_from_uri' implicitly converted to pointer at editor-control-factory.c:251
dannf at krebs:/space/debian/gtkhtml3.8-3.10.1$ cat /tmp/gtkhtml3.8.patch
--- gtkhtml3.8-3.10.0/components/html-editor/editor-control-factory.c.orig     2006-04-28 19:13:45.000000000 -0600
+++ gtkhtml3.8-3.10.0/components/html-editor/editor-control-factory.c   2006-04-28 19:13:33.000000000 -0600
@@ -54,6 +54,7 @@
 #include "Editor.h"

 #include "gtkhtml.h"
+#include "gtkhtml-private.h"
 #include "gtkhtml-properties.h"
 #include "htmlcursor.h"
 #include "htmlengine.h"
dannf at krebs:/space/debian/gtkhtml3.8-3.10.1$ patch -p1 < /tmp/gtkhtml3.8.patch
patching file components/html-editor/editor-control-factory.c
dannf at krebs:/space/debian/gtkhtml3.8-3.10.1$ fakeroot ./debian/rules clean
...
dannf at krebs:/space/debian/gtkhtml3.8-3.10.1$ fakeroot ./debian/rules build 2>&1 | ~/bin/check-implicit-pointer-functions
dannf at krebs:/space/debian/gtkhtml3.8-3.10.1$

-- 
dann frazier