[Evolution] Bug#758653: please enable libphonenumber support

Daniel Pocock daniel at pocock.pro
Mon Sep 1 13:33:54 UTC 2014


On 01/09/14 15:14, Laurent Bigonville wrote:
> Hello all,
>
> I would prefer to only enable this when we are sure that libphonenumber
> is building on all the architectures.

arm64 - this seems to depend on availability of Java (for the
build-deps) on arm64

hurd-i386 - this seems to fail because of dependencies

sparc - this is known to be unstable and there has been talk about
dropping it?


kfreebsd-* - these fail with


 ERROR in /«PKGBUILDDIR»/tools/java/cpp-build/test/com/google/i18n/phonenumbers/BuildMetadataCppFromXmlTest.java (at line 179)
	return new String(headerOut.toByteArray(), UTF_8);
	       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
The constructor String(byte[], Charset) is undefined


Fredrik, could that be fixed in the code?



My feeling is that this dependency could be added for linux-any, e.g. in
debian/control


Build-Depends: ...,
                        libphonenumber6-dev [linux-any],
                         ...

and in debian/rules the relevant code could be wrapped in some
conditional logic to ensure the the configure options for libphonenumber
are only added on Linux, e.g.

ifeq ($(DEB_HOST_ARCH_OS),linux)
CFG_ARGS += --with-phonenumber=/usr
endif


Laurent, would that be acceptable for you?  Do you already take a
similar approach with any other package?

Regards,

Daniel



More information about the Pkg-evolution-maintainers mailing list