[pkg-fetchmail-maint] Bug in postinst

Nico Golde nico at ngolde.de
Mon Nov 14 15:33:14 UTC 2005


Hallo Héctor,

* Héctor García <hector at debian.org> [2005-11-14 16:18]:
> El lun, 14-11-2005 a las 15:37 +0100, Nico Golde escribió:
[...] 
> > > fixing a bug in fetchmail.postinst, there was an extra ! which made the
> > > check wrong and impossible
> > 
> > Sure? I mean this means if /var/run/fetchmail does not 
> > exist.
> 
> Well, just after executing 
> [ -d /var/run/fetchmail ] || mkdir -p /var/run/fetchmail
> /var/run/fetchmail must exits or the script will die (ex: no permision
> while creating it, /var/run/fetchmail existed but was a file instead of
> a dir (should we check that?)

Ah ok now I see what you mean ok, so your fix sounds good.

> Even if it did not exits the check was really weird.
> If the dir doesn't exits go ahead and change its permisions (the script
> would die in pain here)
> 
> >From bash man page:
> 	-d file
>               True if file exists and is a directory.
> 
> Am I missing something?
> Of course, I tested it and in the first case commands were not executed
> while installing the package and they are executed correctly after the
> patch.

Ok, so commit patch to svn.
Regards Nico
-- 
Nico Golde - JAB: nion at jabber.ccc.de | GPG: 0x73647CFF
http://www.ngolde.de | http://www.muttng.org | http://grml.org
Forget about that mouse with 3/4/5 buttons -
gimme a keyboard with 103/104/105 keys!
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
Url : http://lists.alioth.debian.org/pipermail/pkg-fetchmail-maint/attachments/20051114/6078ab8e/attachment.pgp


More information about the pkg-fetchmail-maint mailing list