[pkg-fetchmail-maint] Bug in postinst

[Nico Golde]

Hello Loïc,

* Loïc Minier <lool+alioth at via.ecp.fr> [2005-11-14 17:28]:
> On Mon, Nov 14, 2005, Héctor García wrote:
> > While building next release and testing it I found a bug on
> > fetchmail.postinst
> 
>  Thanks for spotting this.  The fetchmail maintainers did a BAD job at
>  merging the patch I proposed in Debian bug #321272.
[...] 
>  1/ for new installations, the home dir creation has been moved back to
>  adduser, and hence the "if ! [ -d /var/run/fetchmail ]" part will never
>  run in the SVN version of the postinst
> 
>  2/ for the same reason, "[ -d /var/run/fetchmail ] || " is a no-op for
>  new installations
> 
>  3/ even for systems where "fetchmail" already is an user, the "[ -d
>  /var/run/fetchmail ] || mkdir -p /var/run/fetchmail" snipset will
>  ALWAYS create a directory and "if ! [ -d /var/run/fetchmail ];" will
>  ALWAYS fail.
> 
> 
>  That sucks, not only did I spend an infinite amount of time to
>  understand the borkeness of the various versions of your postinsts, but
>  my patch was taken and completely corrupted.
> 
> 
>  Please take patches seriously and test your scripts.
> 
>  Now *please*, keep the adduser part as it is and replace this part:

[...]
Thanks, this patch looks alot better, I will commit it to 
the svn.
Regards Nico
-- 
Nico Golde - JAB: nion at jabber.ccc.de | GPG: 0x73647CFF
http://www.ngolde.de | http://www.muttng.org | http://grml.org
Forget about that mouse with 3/4/5 buttons -
gimme a keyboard with 103/104/105 keys!
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
Url : http://lists.alioth.debian.org/pipermail/pkg-fetchmail-maint/attachments/20051114/9508f842/attachment.pgp