[pkg-fetchmail-maint] Bug#488085: /etc/init.d/fetchmail try-restart should be able to not start fetchmail if it is not running

[florian kriener]

Package: fetchmail
Version: 6.3.9~rc2-2
Severity: wishlist
Tags: patch


I'm using DHCP here on my computer and the client for DHCP starts fetchmail when my computer got a response. The problem is that with that fetchmail is started before postfix and spamd, which is not only ugly but leads to at least one uncheckt spammail per boot. So I investigated that problem and found try-restart behaving like it does, starting the daemon if it is not running already (which, in my opinion, is not intuitive). And so it came to this wishlist item.

To lessen the pain (if you should recon this item), I already made that small change:

diff --git a/debian/fetchmail.default b/debian/fetchmail.default
index c145c37..9e2a5d1 100644
--- a/debian/fetchmail.default
+++ b/debian/fetchmail.default
@@ -9,3 +9,6 @@

 # Declare here if we want to start fetchmail. 'yes' or 'no'
 START_DAEMON=no
+
+# Start fetchmail on try-restart ('normal') or not ('dontstart').
+TRY_RESTART=normal
diff --git a/debian/init b/debian/init
index e5c94ff..8931cb8 100644
--- a/debian/init
+++ b/debian/init
@@ -177,7 +177,9 @@ case "$1" in
                                exit 0
                        fi
                fi
-               test -f /etc/rc`/sbin/runlevel | cut -d' ' -f2`.d/S*fetchmail* && $0 start
+               if [ ! "x$TRY_RESTART" = "xdontstart" ]; then
+                   test -f /etc/rc`/sbin/runlevel | cut -d' ' -f2`.d/S*fetchmail* && $0 start
+               fi
                ;;
        awaken)
                log_begin_msg "Awakening mail retriever agent:" "fetchmail"


-- System Information:
Debian Release: lenny/sid
  APT prefers unstable
  APT policy: (900, 'unstable'), (300, 'testing'), (100, 'experimental')
Architecture: amd64 (x86_64)

Kernel: Linux 2.6.25-2-amd64 (SMP w/2 CPU cores)
Locale: LANG=de_DE.UTF-8, LC_CTYPE=de_DE.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/bash

Versions of packages fetchmail depends on:
ii  adduser               3.108              add and remove users and groups
ii  debianutils           2.29               Miscellaneous utilities specific t
ii  libc6                 2.7-12             GNU C Library: Shared libraries
ii  libcomerr2            1.40.11-1          common error description library
ii  libkrb53              1.6.dfsg.4~beta1-3 MIT Kerberos runtime libraries
ii  libssl0.9.8           0.9.8g-10.1        SSL shared libraries
ii  lsb-base              3.2-12             Linux Standard Base 3.2 init scrip

Versions of packages fetchmail recommends:
ii  ca-certificates               20080617   Common CA certificates

-- no debconf information