[pkg-fgfs-crew] RFS: fgo

[Christopher Baines]

On Fri, 2011-08-05 at 14:53 +0200, Kilian Krause wrote:
> Hi Christopher,
> 
> On Mon, Aug 01, 2011 at 10:29:34AM +0100, Christopher Baines wrote:
> > I am looking for a sponsor for my package "fgo".
> > - dget http://mentors.debian.net/debian/pool/main/f/fgo/fgo_1.3.1-1.dsc
> > 
> > I would be glad if someone uploaded this package for me.
> 
> Reviewing your package I find:
> 
> 1.) You Build-Depends on debhelper 8.9.3 but only use debian/compat 7 - why?

I updated the dependency on debhelper when updating the package to use
dh_python2, I forgot to up the compat level, this is now fixed. 

> 2.) Your Depends has ${python:Depends} but you still spell out python-tk,
>     python-imaging, python-imaging-tk - why aren't they caught by the
>     automagic of dh_python/dh_python2 and need to manually added?

Looking at the manpage for dh_python2, it uses the requires.txt file.
FGo does not have this file, and therefore its dependencies are not tested.  

> 3.) debian/copyright is still at rev. 135 of DEP-5. Please bump to 174 which
>     is final.

Bumped. 

> 4.) The "fix" in debian/rules (mv
>     debian/fgo/usr/share/games/fgo/src/pics/icon.png
>     debian/fgo/usr/share/pixmaps/fgo.png) should be reported upstream and fixed
>     there.

I have removed this and instead linked the icon to the correct
location.

> 5.) debian/watch file is missing

I have tried building one:
version=3
http://sites.google.com/site/erobosprojects/flightgear/add-ons/fgo/download /site/erobosprojects/flightgear/add-ons/fgo/download/fgo-(.+).tar.gz?attredirects=0&d=1

However I get the following error when running it.
uscan warning: In debian/watch,
  no matching hrefs for watch line
  http://sites.google.com/site/erobosprojects/flightgear/add-ons/fgo/download /site/erobosprojects/flightgear/add-ons/fgo/download/fgo-(.+).tar.gz?attredirects=0&d=1

> 6.) Your package fails to build in a clean pbuilder with:
>  fakeroot debian/rules clean
>  dh clean --with python2
>  dh: unable to load addon python2: Can't locate
>  Debian/Debhelper/Sequence/python2.pm in @INC (@INC contains: /etc/perl
>  /usr/local/lib/perl/5.12.4 /usr/local/share/perl/5.12.4 /usr/lib/perl5
>  /usr/share/perl5 /usr/lib/perl/5.12 /usr/share/perl/5.12
>  /usr/local/lib/site_perl .) at (eval 22) line 2.
>  BEGIN failed--compilation aborted at (eval 22) line 2.
> 
>  make: *** [clean] Error 2

This should now be fixed, it definitely builds in pbuilder for me now. 

> Sorry!

That's ok, thanks for taking the time to hi-light these errors. The updated package is available from the debian mentors website.

Thanks again,

Chris

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part
URL: <http://lists.alioth.debian.org/pipermail/pkg-fgfs-crew/attachments/20110806/46b25a4b/attachment.pgp>