[pkg-fgfs-crew] RFS: fgo

Kilian Krause kilian at debian.org
Fri Aug 5 12:53:26 UTC 2011


Hi Christopher,

On Mon, Aug 01, 2011 at 10:29:34AM +0100, Christopher Baines wrote:
> I am looking for a sponsor for my package "fgo".
> - dget http://mentors.debian.net/debian/pool/main/f/fgo/fgo_1.3.1-1.dsc
> 
> I would be glad if someone uploaded this package for me.

Reviewing your package I find:

1.) You Build-Depends on debhelper 8.9.3 but only use debian/compat 7 - why?

2.) Your Depends has ${python:Depends} but you still spell out python-tk,
    python-imaging, python-imaging-tk - why aren't they caught by the
    automagic of dh_python/dh_python2 and need to manually added?

3.) debian/copyright is still at rev. 135 of DEP-5. Please bump to 174 which
    is final.

4.) The "fix" in debian/rules (mv
    debian/fgo/usr/share/games/fgo/src/pics/icon.png
    debian/fgo/usr/share/pixmaps/fgo.png) should be reported upstream and fixed
    there.

5.) debian/watch file is missing

6.) Your package fails to build in a clean pbuilder with:
 fakeroot debian/rules clean
 dh clean --with python2
 dh: unable to load addon python2: Can't locate
 Debian/Debhelper/Sequence/python2.pm in @INC (@INC contains: /etc/perl
 /usr/local/lib/perl/5.12.4 /usr/local/share/perl/5.12.4 /usr/lib/perl5
 /usr/share/perl5 /usr/lib/perl/5.12 /usr/share/perl/5.12
 /usr/local/lib/site_perl .) at (eval 22) line 2.
 BEGIN failed--compilation aborted at (eval 22) line 2.

 make: *** [clean] Error 2


Sorry!

-- 
Best regards,
Kilian
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 190 bytes
Desc: Digital signature
URL: <http://lists.alioth.debian.org/pipermail/pkg-fgfs-crew/attachments/20110805/8e8b7b1b/attachment.pgp>


More information about the pkg-fgfs-crew mailing list