[pkg-fgfs-crew] RFS: fgo

[Christopher Baines]

On Sat, 2011-08-06 at 13:47 +0200, Kilian Krause wrote:
> Hi Christopher,
> 
> On Sat, Aug 06, 2011 at 12:30:33PM +0100, Christopher Baines wrote:
> > On Fri, 2011-08-05 at 14:53 +0200, Kilian Krause wrote:
> > > On Mon, Aug 01, 2011 at 10:29:34AM +0100, Christopher Baines wrote:
> > > > I am looking for a sponsor for my package "fgo".
> > > > - dget http://mentors.debian.net/debian/pool/main/f/fgo/fgo_1.3.1-1.dsc
> > > > 
> > > > I would be glad if someone uploaded this package for me.
> > > 
> > > Reviewing your package I find:
> [...]
> > > 2.) Your Depends has ${python:Depends} but you still spell out python-tk,
> > >     python-imaging, python-imaging-tk - why aren't they caught by the
> > >     automagic of dh_python/dh_python2 and need to manually added?
> > 
> > Looking at the manpage for dh_python2, it uses the requires.txt file.
> > FGo does not have this file, and therefore its dependencies are not tested.  
> 
> as was already discussed on d-mentors I had been under the false impression
> that dh_phython2 would lookup includes and build the Depends from the
> actual *.py files. As this is obviously not the case, I had already
> commented that this requirement is no longer valid and your package is good
> as is.

Sorry, I didn’t see the discussion or the comment.  

> [...]
> > > 5.) debian/watch file is missing
> > 
> > I have tried building one:
> > version=3
> > http://sites.google.com/site/erobosprojects/flightgear/add-ons/fgo/download /site/erobosprojects/flightgear/add-ons/fgo/download/fgo-(.+).tar.gz?attredirects=0&d=1
> > 
> > However I get the following error when running it.
> > uscan warning: In debian/watch,
> >   no matching hrefs for watch line
> >   http://sites.google.com/site/erobosprojects/flightgear/add-ons/fgo/download /site/erobosprojects/flightgear/add-ons/fgo/download/fgo-(.+).tar.gz?attredirects=0&d=1
> 
> The correct way of writing this looks like:
> version=3
> opts="uversionmangle=s/-/\./g" \
> http://sites.google.com/site/erobosprojects/flightgear/add-ons/fgo/download
> /site/erobosprojects/flightgear/add-ons/fgo/download/fgo-(.+).tar.gz\?attredirects=0\&amp\;d=1
> 
> [...]
> 
> For your next upload you might want to also fix:
> I: fgo: desktop-entry-contains-encoding-key usr/share/applications/fgo.desktop:3 Encoding
> and
> P: fgo: no-upstream-changelog
> 
> The upstream ChangeLog is obviously under docs/CHANGE_LOG.

Thanks, I have now fixed these, issues and uploaded the fixed package.

After finally guessing the correct syntax for the lintian config file
(~/.lintianrc), I was able to make the -I and --pedantic options
permanent: 
pedantic = 1
display-info = 1
This might be useful for others.
 
> Anyway,
> Built, Signed, Uploaded (including the debian/watch fix - I'll leave the
> last one up to you).

Thanks,

Chris
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part
URL: <http://lists.alioth.debian.org/pipermail/pkg-fgfs-crew/attachments/20110806/283d9837/attachment.pgp>