[pkg-fgfs-crew] Bug#572428: Bug#572428: BTS Link

Nobuhiro Iwamatsu iwamatsu at nigauri.org
Wed Jan 12 10:40:42 UTC 2011


Hi,

2011/1/12 Ove Kåven <ovek at arcticnet.no>:
> Den 12. jan. 2011 05:11, skrev Nobuhiro Iwamatsu:
>> forwarded 572428 https://sourceforge.net/tracker/?func=detail&aid=3156021&group_id=26352&atid=387125
>> thanks
>>
>> Hi,
>>
>> This problem does not fix 2.0.0.
>> I updated this patch and BTS for upsteam with bts-link.
>
> Note that your patch was/is in direct violation of the comment just
> above those defines ("elaborate games with platform-specific endianness
> headers", which would, of course, include these glibc-specific
> endianness definitions), and upstream has rejected such patches in the
> past (sometimes condescendingly). Remember that it is supposed to be
> possible to build SimGear/FlightGear on FreeBSD, Windows, MacOS, and
> other systems which don't use glibc, so you *can not possibly* "clean
> up" by relying on a glibc-specific feature. If you're going to submit
> patches to upstream, you're probably better off following their
> preferred practice, as you're unlikely to be able to change their minds.
>
> (It would be possible to make something similar a Debian-specific
> modification, though, if there's a good enough reason to diverge from
> upstream on this matter. I'd probably still prefer a patch which does
> not try to "clean up", though.)
>

OK,
I made the patch which supported SuperH only.
I attach it. Could you check this patch?


Best regards,
  Nobuhiro

-- 
Nobuhiro Iwamatsu
   iwamatsu at {nigauri.org / debian.org}
   GPG ID: 40AD1FA6
-------------- next part --------------
A non-text attachment was scrubbed...
Name: simgear_add_support_sh.patch
Type: text/x-patch
Size: 863 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/pkg-fgfs-crew/attachments/20110112/98edb900/attachment.bin>


More information about the pkg-fgfs-crew mailing list