[pkg-fgfs-crew] Bug#252899: Making Terrasync just work

[Rebecca N. Palmer]

I'd consider the real issue here "turning on TerraSync by just ticking 
the box should work".  It currently doesn't, for several reasons:

1) The TerraSync dialog box (Environment > Scenery Download) only allows 
selecting directories that are in FG_SCENERY (so the new scenery will be 
read) but not FG_ROOT/Scenery (as noted above, TerraSync isn't meant to 
be run there).  By default, FG_SCENERY = FG_ROOT/Scenery, so there are 
no directories available for selection and TerraSync hence can't be 
turned on.  (The dialog script then tries, and fails, to display an 
error message stating this: fixed by terrasync_error_display.patch)

I suggest including the TerraSync directory in the default scenery 
directories even if TerraSync is currently off, both to allow it to be 
turned on from this dialog box, and to keep displaying existing 
TerraSync scenery if the user later disables new downloads (e.g. because 
they are running out of data allowance).  This is done by 
terrasync_directory.patch.

This patch does not change the default TerraSync directory (currently 
$HOME/.fgfs/TerraSync, which will be created if necessary); this can 
easily be changed in flightgear/src/Main/options.cxx near line 2050, but 
using a shared directory (such as /var/games/flightgear/TerraSync) would 
require either making all the downloaded files world-writable (which 
libsvn doesn't appear to provide a way to do) or making FlightGear 
setgid (allowed by Policy 11.11, but would it be a good idea 
security-wise?).

2) If one uses Select Airport to go to a less-negative lat/long (e.g. 
KSFO to nearly anywhere else in the Americas) the tile one is now in is 
not downloaded, as the tile selection process rounds the lat/long 
towards 0 but the tile names are rounded down.  Fixed by 
terrasync_fix_rounding.patch.

3) Select Airport does not wait for the new scenery to become available, 
so to see it one has to refresh scenery (to load it) then Select Airport 
again (to get to the new ground level).  I don't have an actual fix for 
that yet, but terrasync_document_ground_refresh.patch adds a note 
stating this workaround.

These patches were tested together (in upstream 2.12rc) but should all 
be independent.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: terrasync_directory.patch
Type: text/x-patch
Size: 2117 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/pkg-fgfs-crew/attachments/20130926/98f34e7e/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: terrasync_fix_error_display.patch
Type: text/x-patch
Size: 797 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/pkg-fgfs-crew/attachments/20130926/98f34e7e/attachment-0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: terrasync_fix_rounding.patch
Type: text/x-patch
Size: 818 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/pkg-fgfs-crew/attachments/20130926/98f34e7e/attachment-0002.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: terrasync_document_ground_refresh.patch
Type: text/x-patch
Size: 979 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/pkg-fgfs-crew/attachments/20130926/98f34e7e/attachment-0003.bin>