[pkg-fgfs-crew] Bug#750859: flightgear: Crashes on some scenery objects: strutils.cxx:65:utf8ToLatin1: wrong char value

[Ludovic Brenta]

Package: flightgear
Version: 3.0.0-2
Severity: important

Hello,

FlightGear crashes when loading certain tiles downloaded using
TerraSync.  One particular tile can reproduce the crash reliably; here
is a recipe:

* Start FlightGear Launch Control (aka fgrun)
* On the first page, the type of aircraft does not seem to matter.
* On the second page, click "All Airports" then type EDDR (Saarbrucken).
* On the third page, enable TerraSync.
* Run.
* Be patient while FlightGear downloads the scenery for northeastern
  France and parts of Germany (if you don't have those tiles yet).
* Open the map (Equipment > Map); it starts at zoom level 6 for me by
  default, helping pinpoint the object that triggers the problem.
* Tick "Data".

This causes FlightGear to crash, leaving a 80-MiB log file in
~/.fgfs/fgfs.log.  The last messages in this log file are:

terrain:3:/usr/src/simgear.git/simgear/scene/tgdb/ReaderWriterSTG.cxx:256:Loading stg file /home/lbrenta/.fgfs/TerraSync/Terrain/e000n40/e007n49/3072728.stg
io:4:/usr/src/simgear.git/simgear/misc/strutils.cxx:65:utf8ToLatin1: wrong char value: 4294967168

(this last line repeated millions of times with different numbers).

I suspect a bug in strutils.cxx wherein the UTF-8 parser fails to
recover from incorrect UTF-8 input.  For that matter, the implementation
of utf8ToLatin1 seems incorrect to me as it ignores the high-order bits
of every byte, only checking one bit per byte of input.

The "terrain:" message changes at each crash but the first "wrong char
value" is always the same; for example I also got:

terrain:3:/usr/src/simgear.git/simgear/scene/tgdb/ReaderWriterSTG.cxx:256:Loading stg file /home/lbrenta/.fgfs/TerraSync/Terrain/e000n40/e006n48/3056307.stg
io:4:/usr/src/simgear.git/simgear/misc/strutils.cxx:65:utf8ToLatin1: wrong char value: 4294967168

terrain:3:/usr/src/simgear.git/simgear/scene/tgdb/ReaderWriterSTG.cxx:256:Loading stg file /home/lbrenta/.fgfs/TerraSync/Terrain/e000n40/e006n48/3056315.stg
io:4:/usr/src/simgear.git/simgear/misc/strutils.cxx:65:utf8ToLatin1: wrong char value: 4294967168

this suggests that the "terrain" message might be unrelated to the "io"
message.

For completeness, here is the complete command line I used to launch
FlightGear:

/usr/games/fgfs
  --fg-root=/usr/share/games/flightgear
  --fg-scenery=/usr/share/games/flightgear/Scenery
  --airport=EDDR
  --aircraft=SenecaII
  --control=mouse
  --disable-random-objects
  --disable-hud-3d
  --enable-auto-coordination
  --disable-ai-models
  --disable-ai-traffic
  --disable-real-weather-fetch
  --enable-clouds3d
  --prop:/sim/frame-rate-throttle-hz=60
  --geometry=1920x1200
  --bpp=32
  --enable-terrasync
  --disable-fgcom

-- System Information:
Debian Release: jessie/sid
  APT prefers testing
  APT policy: (10000, 'testing')
Architecture: amd64 (x86_64)

Kernel: Linux 3.14-1-amd64 (SMP w/8 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

Versions of packages flightgear depends on:
ii  flightgear-data-all       3.0.0-1
ii  freeglut3                 2.8.1-2
ii  libc6                     2.18-7
ii  libdbus-1-3               1.8.2-1
ii  libgcc1                   1:4.9.0-5
ii  libgl1-mesa-glx [libgl1]  10.1.4-1
ii  libglu1-mesa [libglu1]    9.0.0-2
ii  libgsm1                   1.0.13-4
ii  libice6                   2:1.0.8-2
ii  libjpeg8                  8d-2
ii  libopenal1                1:1.14-4
ii  libopenscenegraph99       3.2.0~rc1-5.1
ii  libopenthreads14          3.2.0~rc1-5.1
ii  libplib1                  1.8.5-7
ii  libpng12-0                1.2.50-1
ii  libsimgearcore3.0.0       3.0.0-3
ii  libsimgearscene3.0.0      3.0.0-3
ii  libsm6                    2:1.2.1-2
ii  libspeex1                 1.2~rc1.1-1
ii  libspeexdsp1              1.2~rc1.1-1
ii  libsqlite3-0              3.8.4.3-3
ii  libstdc++6                4.9.0-5
ii  libudev1                  204-8
ii  libx11-6                  2:1.6.2-2
ii  libxext6                  2:1.3.2-1
ii  libxi6                    2:1.7.2-1
ii  libxmu6                   2:1.1.2-1
ii  zlib1g                    1:1.2.8.dfsg-1

flightgear recommends no packages.

flightgear suggests no packages.

-- no debconf information