[pkg-fgfs-crew] [flightgear-data] 05/06: Replace about 12500 chmod calls with approx. 1

Markus Wanner markus_wanner-guest at moszumanska.debian.org
Wed Feb 11 07:57:49 UTC 2015


This is an automated email from the git hooks/post-receive script.

markus_wanner-guest pushed a commit to branch experimental
in repository flightgear-data.

commit ed1a0698df4eb9fb69d63f9f6439296e036fb298
Author: Florent Rougon <f.rougon at free.fr>
Date:   Mon Nov 3 14:51:05 2014 +0100

    Replace about 12500 chmod calls with approx. 1
    
    debian/rules: replace a call of the form:
    
      find ... -type f -exec chmod 644 {} \;
    
    with:
    
      find ... -type f -execdir chmod 644 '{}' +
    
    which does the same with a minimum number of invocations of the chmod
    command (from the find(1) Info documentation: "This expansion is done in
    such a way as to avoid exceeding the maximum command line length
    available on the system").
    
    Note: according to the same documentation, -execdir is more secure than
          -exec, however I don't think it has any impact in this case.
    
    Signed-off-by: Markus Wanner <markus at bluegap.ch>
---
 debian/rules | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/debian/rules b/debian/rules
index 0be03d6..e216a13 100755
--- a/debian/rules
+++ b/debian/rules
@@ -78,7 +78,7 @@ override_dh_auto_install:
 
 # Fix some insane permissions
 	find $(CURDIR)/debian/flightgear-data-*/usr/share/games/flightgear \
-		-type f -exec chmod 644 {} \;
+		-type f -execdir chmod 644 '{}' +
 	chmod a+x $(CURDIR)/debian/flightgear-data-base/usr/share/games/flightgear/Textures.high/Trees/convert.pl
 
 # Drop some silly Windows PE32 executable files

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/collab-maint/flightgear-data.git



More information about the pkg-fgfs-crew mailing list