[pkg-fgfs-crew] Preparing for flightgear 2016.x

[Rebecca N. Palmer]

We don't need an epoch in the version number (as Alioth's 
simgear/flightgear currently have), as 2016.1.1 already sorts after 3.4.0.

The attached includes a few more changes (replace the fragile list with 
"everything we don't specify elsewhere goes in flightgear-data-base", 
drop flightgear-data-aircrafts as upstream is now c172p+ufo only, also 
minify knockout), and now has been tested in a full build+run (though 
with upstream taken from the git branch, not their tarball) and appears 
to work.  However, it isn't perfect yet, as Lintian points out:

Things we should probably fix:

P: flightgear-data source: source-contains-prebuilt-javascript-object 
Aircraft/c172p/WebPanel/bootstrap/bootstrap.min.js
E: flightgear-data source: source-is-missing 
Aircraft/c172p/WebPanel/bootstrap/bootstrap.min.js

I didn't notice this one; it is available in Debian as libjs-bootstrap.

P: flightgear-data source: package-uses-old-debhelper-compat-version 7
W: flightgear-data source: out-of-date-standards-version 3.9.6 (current 
is 3.9.7)

Probably OK to just change (debhelper will also need the version in 
Build-Depends updating).

I: flightgear-data source: vcs-field-uses-insecure-uri vcs-git 
git://anonscm.debian.org/collab-maint/flightgear-data.git
I: flightgear-data source: vcs-field-uses-insecure-uri vcs-browser 
http://anonscm.debian.org/gitweb/?p=collab-maint/flightgear-data.git

Simple to fix: https://anonscm.debian.org/git/collab-maint/<package>.git 
now works for both cloning and browsing 
(https://lists.debian.org/debian-devel/2016/01/msg00333.html).

I: flightgear-data source: wildcard-matches-nothing-in-dep5-copyright 
Aircraft/Cub/* (paragraph at line 16)
I: flightgear-data source: unused-file-paragraph-in-dep5-copyright 
paragraph at line 16
W: flightgear-data-base: extra-license-file 
usr/share/games/flightgear/Aircraft/c172p/LICENSE
W: flightgear-data-base: extra-license-file 
usr/share/games/flightgear/COPYING
W: flightgear-data-base: extra-license-file 
usr/share/games/flightgear/Phi/3rdparty/pagedown/LICENSE.txt

Probably also needs a more general debian/copyright update, at least for 
the JavaScript bits.

P: flightgear-data source: source-contains-prebuilt-javascript-object 
debian/missing-sources/Leaflet.Geodesic-master/Leaflet.Geodesic.min.js
P: flightgear-data source: source-contains-prebuilt-javascript-object 
debian/missing-sources/jui_theme_switch-master/jquery.jui_theme_switch.min.js
P: flightgear-data source: source-contains-prebuilt-javascript-object 
debian/missing-sources/clockpicker-gh-pages/dist/bootstrap-clockpicker.min.js
P: flightgear-data source: source-contains-prebuilt-javascript-object 
debian/missing-sources/clockpicker-gh-pages/dist/jquery-clockpicker.min.js
P: flightgear-data source: source-contains-prebuilt-javascript-object 
debian/missing-sources/clockpicker-gh-pages/assets/js/bootstrap.min.js
P: flightgear-data source: source-contains-prebuilt-javascript-object 
debian/missing-sources/clockpicker-gh-pages/assets/js/highlight.min.js
E: flightgear-data source: source-is-missing 
debian/missing-sources/clockpicker-gh-pages/assets/js/highlight.min.js
P: flightgear-data source: insane-line-length-in-source-file 
debian/missing-sources/clockpicker-gh-pages/assets/js/html5shiv.js line 
length is 645 characters (>512)
P: flightgear-data source: source-contains-prebuilt-javascript-object 
debian/missing-sources/clockpicker-gh-pages/assets/js/html5shiv.js line 
length is 645 characters (>512)
E: flightgear-data source: source-is-missing 
debian/missing-sources/clockpicker-gh-pages/assets/js/html5shiv.js line 
length is 645 characters (>512)
P: flightgear-data source: source-contains-prebuilt-javascript-object 
debian/missing-sources/clockpicker-gh-pages/assets/js/jquery.min.js
P: flightgear-data source: source-contains-prebuilt-javascript-object 
debian/missing-sources/clockpicker-gh-pages/assets/js/respond.min.js
E: flightgear-data source: source-is-missing 
debian/missing-sources/clockpicker-gh-pages/assets/js/respond.min.js
P: flightgear-data source: insane-line-length-in-source-file 
debian/missing-sources/knockout-3.2.0/dist/knockout.js line length is 
523 characters (>512)
P: flightgear-data source: source-contains-prebuilt-javascript-object 
debian/missing-sources/knockout-3.2.0/dist/knockout.js line length is 
523 characters (>512)
P: flightgear-data source: insane-line-length-in-source-file 
debian/missing-sources/knockout-3.2.0/spec/lib/innershiv.js line length 
is 937 characters (>512)
P: flightgear-data source: source-contains-prebuilt-javascript-object 
debian/missing-sources/knockout-3.2.0/spec/lib/innershiv.js line length 
is 937 characters (>512)
E: flightgear-data source: source-is-missing 
debian/missing-sources/knockout-3.2.0/spec/lib/innershiv.js line length 
is 937 characters (>512)

We don't use these, so they can simply be deleted.

W: flightgear-data-base: script-not-executable 
usr/share/games/flightgear/Aircraft/c172p/dev/fdm/gerris/create_experiment.sh
W: flightgear-data-base: script-not-executable 
usr/share/games/flightgear/Aircraft/c172p/dev/fdm/gerris/run_experiment.sh
W: flightgear-data-base: script-not-executable 
usr/share/games/flightgear/Aircraft/c172p/dev/fdm/gerris/summarize_experiment_jsbsim.sh
W: flightgear-data-base: script-not-executable 
usr/share/games/flightgear/Phi/mkthemes.sh
W: flightgear-data-base: script-not-executable 
usr/share/games/flightgear/Textures/Trees/convert.pl

Simple to fix (if these things are even in the tarball - I did this test 
using an upstream from git repo).

Non-issues (though the E: should probably be overridden):

P: flightgear-data source: insane-line-length-in-source-file 
Phi/3rdparty/pagedown/Markdown.Converter.js line length is 4155 
characters (>512)
P: flightgear-data source: source-contains-prebuilt-javascript-object 
Phi/3rdparty/pagedown/Markdown.Converter.js line length is 4139 
characters (>512)
E: flightgear-data source: source-is-missing 
Phi/3rdparty/pagedown/Markdown.Converter.js line length is 4139 
characters (>512)

This _is_ source (un-minified JavaScript), it just happens to contain a 
very long one-line initialization (lettersThatJavaScriptDoesNotKnowAndQ).

P: flightgear-data source: debian-watch-may-check-gpg-signature

It can't because upstream don't provide one.

W: flightgear-data-base: package-contains-timestamped-gzip 
usr/share/games/flightgear/Aircraft/c172p/dev/blender.tar.gz
W: flightgear-data-base: package-contains-timestamped-gzip 
usr/share/games/flightgear/Airports/apt.dat.gz
W: flightgear-data-base: package-contains-timestamped-gzip 
usr/share/games/flightgear/Airports/metar.dat.gz
W: flightgear-data-base: package-contains-timestamped-gzip 
usr/share/games/flightgear/Astro/planets.gz
W: flightgear-data-base: package-contains-timestamped-gzip 
usr/share/games/flightgear/Astro/stars.gz
W: flightgear-data-base: package-contains-timestamped-gzip 
usr/share/games/flightgear/Navaids/TACAN_freq.dat.gz
W: flightgear-data-base: package-contains-timestamped-gzip 
usr/share/games/flightgear/Navaids/awy.dat.gz
W: flightgear-data-base: package-contains-timestamped-gzip 
usr/share/games/flightgear/Navaids/carrier_nav.dat.gz
W: flightgear-data-base: package-contains-timestamped-gzip 
usr/share/games/flightgear/Navaids/fix.dat.gz
W: flightgear-data-base: package-contains-timestamped-gzip 
usr/share/games/flightgear/Navaids/nav.dat.gz
W: flightgear-data-base: package-contains-timestamped-gzip 
usr/share/games/flightgear/Navaids/poi.dat.gz

Not a reproducibility problem because these are copied with -a from the 
source, not created during the build.

Technically correct, but I'd ignore them:

I: flightgear-data-base: font-in-non-font-package 
usr/share/games/flightgear/Fonts/7-Segment.ttf
I: flightgear-data-base: font-in-non-font-package 
usr/share/games/flightgear/Fonts/BoeingCDU-Large.ttf
I: flightgear-data-base: font-in-non-font-package 
usr/share/games/flightgear/Fonts/BoeingCDU-Small.ttf
I: flightgear-data-base: font-in-non-font-package 
usr/share/games/flightgear/Fonts/LED-16.ttf
I: flightgear-data-base: font-in-non-font-package 
usr/share/games/flightgear/Fonts/LED-8.ttf
-------------- next part --------------
A non-text attachment was scrubbed...
Name: fgdata_phi2.diff
Type: text/x-diff
Size: 28689 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/pkg-fgfs-crew/attachments/20160220/8c4bc448/attachment-0001.diff>