[pkg-fgfs-crew] Status of FGo!

[Florent Rougon]

Hi again Markus,

Just for the record:

Florent Rougon <f.rougon at free.fr> wrote:

> The packaging I provide is probably not too bad, but not perfect either:
>
> E: ffgo source: source-is-missing
> docs/README.conditional-config/_static/jquery.js
> E: ffgo source: source-is-missing
> docs/README.conditional-config/_static/underscore.js

These turned out to be lintian false positives:

 1) The files aren't shipped in any way with FFGo (be it upstream or in
    the Debian package); they are copied there by sphinx-build from the
    python3-sphinx package (sphinx-build being run at build time).

 2) Building the ffgo package runs dh_sphinxdoc, which does the right
    thing: the corresponding files in the ffgo binary package are
    replaced with symlinks to files in
    '/usr/share/javascript/sphinxdoc/1.0/', which are clearly in source
    form (not minified).

I thus added a lintian override for these two.

> W: ffgo: image-file-in-usr-lib
> usr/lib/python3/dist-packages/ffgo/data/pics/thumbnail-no-Pillow.gif
> W: ffgo: image-file-in-usr-lib
> usr/lib/python3/dist-packages/ffgo/data/pics/thumbnail-not-avail.png
>
> The .js files are created (copied) by the Sphinx documentation system.
> As for the image files, some shuffling around with a symlink would
> certainly do, but given the IMHO uselessness of this lib vs. share
> distinction in today's systems, compared to the burden it creates for
> Python packaging, I didn't waste time "fixing" it for an unofficial
> package.

Actually, I *had* wasted that time for the initial packaging, but the
code doing that was only half-working nowadays, causing the files to be
duplicated: one for each under /usr/share and under /usr/lib. The root
cause for this little problem appears to be that I had put python3-all
in Build-Depends, which caused the package to be built with both Python
3.4 and 3.5 on current 'unstable'. At the end of the build (after my
symlinking for these files), dh_python3 was moving files from
debian/ffgo/usr/lib/python3.x/dist-packages to
debian/ffgo/usr/lib/python3/dist-packages for x in (4, 5), which ended
up in the same location for both x=4 and x=5... Replacing the build-dep
on python3-all with a build-dep on python3 fixed this problem, and one
can see in the build log that only Python 3.5 is used for the build.
(fixed package: ffgo 1.9.1-1~frougon+deb9u1)

As for the Lintian warning, it wouldn't have been printed had I built a
few hours later with lintian 2.5.40 (upgrade delayed by the Perl
transition, I think). The policy requirement for
architecture-independent application-specific static files to be located
in /usr/share has been relaxed to a simple suggestion (being globally
counter-productive IMHO):

  https://www.debian.org/doc/debian-policy/ch-opersys.html#s9.1
  (§ 9.1.1)

and lintian 2.5.40 only prints it in pedantic mode. For more info on
this:

  https://lists.debian.org/debian-python/2015/05/msg00040.html
  https://lists.debian.org/debian-python/2015/05/msg00053.html
  https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=415558

Regards

-- 
Florent