[pkg-fgfs-crew] Bug#837452: simgear: Please build libSimGearCore.a and libSimGearScene.a with -fPIC

[Balint Reczey]

Source: simgear
Version: 1:2016.2.1+dfsg-6
Severity: important
User: balint at balintreczey.hu
Usertags: pie-bindnow-20160906
Justification: makes several packages FTBFS with extra hardening
Affects:fgrun flightgear

Dear Maintainers,

During a rebuild of all packages in sid, several packages
failed to build on amd64 with patched GCC and dpkg. The root
cause seems to be that libSimGearCore.a is shipped as a non-PIC library.

The rebuild tested if packages are ready for a transition
enabling PIE and bindnow for amd64.

For more information about the changes to sid's dpkg and GCC please
visit:
 https://wiki.debian.org/Hardening/PIEByDefaultTransitio

Relevant part of fgrun's build log:
...
/usr/bin/c++   -g -O2 -fdebug-prefix-map=/<<PKGBUILDDIR>>=.
-fstack-protector-strong -Wformat -Werror=
format-security -Wdate-time -D_FORTIFY_SOURCE=2   -D_REENTRANT
-DENABLE_NLS -g -DNDEBUG   -Wl,-z,relro
 -Wl,-z,now  CMakeFiles/fgrun.dir/wizard_funcs.cxx.o
CMakeFiles/fgrun.dir/advanced_funcs.cxx.o CMakeFi
les/fgrun.dir/AirportBrowser.cxx.o
CMakeFiles/fgrun.dir/AirportTable.cxx.o CMakeFiles/fgrun.dir/Fl_Tab
le.cxx.o CMakeFiles/fgrun.dir/Fl_Table_Row.cxx.o
CMakeFiles/fgrun.dir/Fl_OSG.cxx.o CMakeFiles/fgrun.di
r/Fl_Heading_Dial.cxx.o CMakeFiles/fgrun.dir/main.cxx.o
CMakeFiles/fgrun.dir/io.cxx.o CMakeFiles/fgrun
.dir/fgfsrc.cxx.o CMakeFiles/fgrun.dir/logwin.cxx.o
CMakeFiles/fgrun.dir/parkingloader.cxx.o CMakeFile
s/fgrun.dir/settings.cxx.o CMakeFiles/fgrun.dir/util.cxx.o
CMakeFiles/fgrun.dir/run_posix.cxx.o CMakeF
iles/fgrun.dir/fgrun_pty.cxx.o  -o fgrun -rdynamic libWizard.a
libAdvanced.a -Wl,-Bstatic -lSimGearSce
ne -lSimGearCore -lSimGearCore -Wl,-Bdynamic -losgText -losgDB
-losgParticle -losgUtil -losgViewer -lo
sgGA -losg -lOpenThreads /usr/lib/x86_64-linux-gnu/libfltk_forms.so
/usr/lib/x86_64-linux-gnu/libfltk_
gl.so /usr/lib/x86_64-linux-gnu/libfltk_images.so
/usr/lib/x86_64-linux-gnu/libfltk.so -ldl -ldl -lz -
lutil -lGLU -lGL -ldl -lpthread -lexpat -lz -lutil -lGLU -lGL -lpthread
-lexpat
/usr/bin/ld:
/usr/lib/gcc/x86_64-linux-gnu/6/../../../x86_64-linux-gnu/libSimGearScene.a(ModelRegistry
.cxx.o): relocation R_X86_64_32 against `.rodata' can not be used when
making a shared object; recompi
le with -fPIC
...

The full build log is available from:
https://people.debian.org/~rbalint/build-logs/pie-bindnow-20160906/fgrun_3.4.0.final-3_amd64.build.gz

Thanks,
Balint