[pkg-firebird-general] Bug#769647: unblock: firebird2.5/firebird2.5_2.5.3.26778.ds4-4

[Damyan Ivanov]

Package: release.debian.org
Severity: normal
User: release.debian.org at packages.debian.org
Usertags: unblock

Please unblock package firebird2.5

Version 2.5.3.26778.ds4-4 has a fix for #769161 which would cause data 
corruption when transferring data between the client and the server 
when one is on ppc64el and the other is not.

The reason for the bug is that ppc64el is mis-detected as powerpc in 
the configure script. Since firebird entangles endianness information 
with so called "Implementation ID", having an implementation ID 
associated with wrong endianness would cause either wrong or missing 
conversion between native and network byte-order.

The evidence of architecture misdetection can be found int he build 
log of version 2.5.3.26778.ds4-3[1] (look for "access method"):

  Firebird/linux PowerPC (access method), version "LI-V2.5.3.26778 
  Firebird 2.5".

In contrast, -4 build log[2] on ppc64el has

  Firebird/linux PPC64EL (access method), version "LI-V2.5.3.26778 
  Firebird 2.5"

[1] https://buildd.debian.org/status/fetch.php?pkg=firebird2.5&arch=ppc64el&ver=2.5.3.26778.ds4-3+b1&stamp=1415464014
[2] https://buildd.debian.org/status/fetch.php?pkg=firebird2.5&arch=ppc64el&ver=2.5.3.26778.ds4-4&stamp=1416001679


========= Patch description ============
add implementation ID for ppc64el architecture

Without this, binaries built on ppc64el use the implementation ID of powerpc,
which is big-endian, while ppc64el is little-endian. Wrong information about
endianness will cause data corruption when transferring big integers and
doubles over the network between ppc64el and other architectures.

The patch is taken from revisions 60194-60204 of upstream's B2_5_Release
branch with the following modifications:
 + the part that enables arm64 is omitted, since we already have a separate
   patch for that, upstream/r58859-arm64.patch
 + some white-space changes are trimmed so that the patch is to the point
Bug-Debian: https://bugs.debian.org/769161
Origin: upstream; https://anonscm.debian.org/cgit/pkg-firebird/upstream.git/log/?h=B2_5_Release
========================================

The full patch text is available at 
https://anonscm.debian.org/cgit/pkg-firebird/2.5.git/tree/debian/patches/upstream/r60194-60204-ppcel.patch

Debdiff attached.

I have built the package with that patch on pastel (ppc64el porter 
box) and amd64. It built fine, and this alone gives me enough 
confidence that there's no unexpected breakage, since the engine is 
used as a part of the build process.

It is also green[3] on all buildds.

 [3] https://buildd.debian.org/status/package.php?p=firebird2.5

unblock firebird2.5/firebird2.5_2.5.3.26778.ds4-4


Thanks,
    dam

-- System Information:
Debian Release: jessie/sid
  APT prefers stable-updates
  APT policy: (500, 'stable-updates'), (500, 'unstable'), (500, 'stable'), (1, 'experimental')
Architecture: amd64 (x86_64)

Kernel: Linux 3.16.0-4-amd64 (SMP w/4 CPU cores)
Locale: LANG=bg_BG.UTF-8, LC_CTYPE=bg_BG.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
-------------- next part --------------
A non-text attachment was scrubbed...
Name: firebird2.5-debdiff.diff
Type: text/x-diff
Size: 6844 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/pkg-firebird-general/attachments/20141115/6790adaf/attachment-0001.diff>