Bug#853424: gnash: ftbfs with GCC-7

[John Horigan]

It is unfortunate that the author of revision 63 chose to remove rgba8_pre,
rather than create linear and sRGB variants.

If you replace agg::rgba8_pre(r,g,b,a) with
agg::rgba8(r,g,b,a).premultiply() it should work for both the old and new
versions of libagg

-- john

On Sat, Dec 16, 2017 at 12:11 AM Juhani Numminen <juhaninumminen0 at gmail.com>
wrote:

> Control: retitle 853424 gnash: FTBFS with agg 1:2.4-r127+dfsg1-1
>
> Hi,
>
> This is the first warning in my build log (attached):
>
> make[4]: Entering directory
> '/build/gnash-0.8.11~git20160608/tmp.build/librender'
>   CXX      libgnashrender_la-Renderer_agg.lo
> In file included from ../../librender/agg/Renderer_agg.cpp:146:0:
> ../../librender/agg/Renderer_agg_style.h: In member function 'void
> gnash::AddStyles::operator()(const gnash::SolidFill&) const':
> ../../librender/agg/Renderer_agg_style.h:617:28: error: 'rgba8_pre' is not
> a member of 'agg'
>          _sh.add_color(agg::rgba8_pre(color.m_r, color.m_g, color.m_b,
>                             ^~~~~~~~~
> ../../librender/agg/Renderer_agg_style.h:617:28: note: suggested
> alternative: 'rgba_pre'
>          _sh.add_color(agg::rgba8_pre(color.m_r, color.m_g, color.m_b,
>                             ^~~~~~~~~
>
> It seems that rgba8_pre really was removed from the headers in the last
> upload of agg.
>
> https://sources.debian.org/src/agg/2.5+dfsg1-11/include/agg_color_rgba.h/#L436
>
> https://sources.debian.org/src/agg/1:2.4-r127+dfsg1-1/include/agg_color_rgba.h
>
> In the upstream repository, the removal was done in revision 63.
> https://sourceforge.net/p/agg/svn/63/?page=2#diff-17
>
> https://sourceforge.net/p/agg/svn/63/tree/agg-2.4/include/agg_color_rgba.h?diff=518286af2718467b8b34c637:62
>
>
> Best regards,
> Juhani
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.alioth.debian.org/pipermail/pkg-flash-devel/attachments/20171216/8b09e86b/attachment.html>