[Pkg-fonts-bugs] Bug#809933: [Pkg-fonts-devel] Bug#809933: fontforge: FTBFS with libpng16

[Daniel Kahn Gillmor]

Control: affects 809933 libgif-dev

On Mon 2016-01-04 17:38:00 -0500, tobi at debian.org wrote:
> Currently we are preparing the transistion of libpng1.2 to libpng1.6.
> The transistion bug is #650601.

thanks for the report and updates, tobi!

> fontforge FTBFS during this rebuild. The buildlog is available at
> https://libpng.sviech.de/fontforge.build

fwiw, the errors here are:

libtool: compile:  gcc -g -O0 -fstack-protector-strong -Wformat -Werror=format-security -I/usr/include/freetype2/ -I/usr/include/freetype2 -I/usr/include/libxml2/ -I/usr/include/cairo -I/usr/include/pango-1.0 -I/usr/include/harfbuzz -I/usr/include/pango-1.0 -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -I/usr/include/freetype2 -I/usr/include/pango-1.0 -I/usr/include/harfbuzz -I/usr/include/pango-1.0 -I/usr/include/cairo -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -I/usr/include/pixman-1 -I/usr/include/freetype2 -I/usr/include/libpng16 -I/usr/include/python2.7 -I../inc -I../inc -I/usr/pkg/include -I/usr/pkg/include/giflib -Wmissing-prototypes -Wunused -Wimplicit -Wreturn-type -Wparentheses -Wformat -Wchar-subscripts -DNOTHREADS -DHAVE_CONFIG_H -DLIBDIR=\"/usr/lib\" -c gimagereadgif.c  -fPIC -DPIC -o .libs/gimagereadgif.o
gimagereadgif.c: In function 'GImageReadGif':
gimagereadgif.c:223:16: error: too few arguments to function 'DGifOpenFileName'
     if ((gif = DGifOpenFileName(filename)) == NULL) {
                ^
In file included from gimagereadgif.c:162:0:
/usr/include/gif_lib.h:179:14: note: declared here
 GifFileType *DGifOpenFileName(const char *GifFileName, int *Error);
              ^
gimagereadgif.c:229:2: error: too few arguments to function 'DGifCloseFile'
  DGifCloseFile(gif);
  ^
In file included from gimagereadgif.c:162:0:
/usr/include/gif_lib.h:183:9: note: declared here
     int DGifCloseFile(GifFileType * GifFile, int *ErrorCode);
         ^
gimagereadgif.c:241:5: error: too few arguments to function 'DGifCloseFile'
     DGifCloseFile(gif);
     ^
In file included from gimagereadgif.c:162:0:
/usr/include/gif_lib.h:183:9: note: declared here
     int DGifCloseFile(GifFileType * GifFile, int *ErrorCode);
         ^
Makefile:54: recipe for target 'gimagereadgif.lo' failed


This looks like a change in giflib, not in libpng.  It was added in
version 5.0.0 of giflib, which entered unstable on 2015-12-12 (NMU by
doko, cc'ed here).

Doko, is this giflib change part of a transition as well?

        --dkg