[Pkg-freeipmi-devel] Bug#690040: freeipmi: Build with PIE, bindnow, openfiles with O_EXCL and check return status

[Yaroslav Halchenko]

ok -- let's then just wait for Dave's feedback -- it might be that this
all came up purely from code introspection and indeed not pertinent per
se.

On Tue, 09 Oct 2012, Albert Chu wrote:

> >   * debian/patches/0002_excel_when_opening_tmp.patch: Open files with
> O_EXCL.

> Sorry, I think I got confused when I first read this and the code.

> Now that I'm looking through the code, the debug data is dumped
> to /var/log/ipmiconsole.  It's only when FreeIPMI is being compiled in
> debug/developer mode that files are temporarily stored in /tmp.  So we
> shouldn't consider the storage of files into /tmp the normal
> production/release case.

> So I'm even more confused now on the need for O_EXCL.  The production
> case is exactly what you'd want.  Files stored into /var/log/ipmiconsole
> and already existing is ok.

besides two ipmiconsoles trying to write into the same file, right
-- or do you expect that work just fine?

-- 
Yaroslav O. Halchenko
Postdoctoral Fellow,   Department of Psychological and Brain Sciences
Dartmouth College, 419 Moore Hall, Hinman Box 6207, Hanover, NH 03755
Phone: +1 (603) 646-9834                       Fax: +1 (603) 646-1419
WWW:   http://www.linkedin.com/in/yarik