[Pkg-freevo-maint] Bug#489590: freevo: bashism in /bin/sh script

[Raphael Geissert]

Package: freevo
Severity: important
Version: 1.8.1-0
User: debian-release at lists.debian.org
Usertags: goal-dash

Hello maintainer,

While performing an archive wide checkbashisms (from the 'devscripts' package) 
check I've found your package containing one or more /bin/sh scripts making 
use of bashisms.

checkbashisms' output:
> possible bashism in ./usr/share/freevo/contrib/fbcon/mgafb line 31 (should
> be 'b = a'): 
> if [ "$1" == "restore" ]; then 
> possible bashism in ./usr/share/freevo/contrib/fbcon/mgafb line 54 (should
> be 'b = a'): 
> if ! [ "$1" == "pal" ] && ! [ "$1" == "PAL" ] && \ 
> possible bashism in ./usr/share/freevo/contrib/fbcon/mgafb line 55 (should
> be 'b = a'): 
> ! [ "$1" == "ntsc" ] && ! [ "$1" == "NTSC" ]; then 
> possible bashism in ./usr/share/freevo/contrib/fbcon/mgafb line 69 (should
> be 'b = a'):
> if [ "$1" == "pal" ] || [ "$1" == "PAL" ]; then 
> possible bashism in ./usr/share/freevo/contrib/fbcon/mgafb line 73 (should
> be 'b = a'): 
> if [ "$2" == "768x576" ]; then 
> possible bashism in ./usr/share/freevo/contrib/fbcon/mgafb line 83 (should
> be 'b = a'):
> elif [ "$2" == "800x600" ]; then 
> possible bashism in ./usr/share/freevo/contrib/fbcon/mgafb line 96 (should
> be 'b = a'):
> if [ "$2" == "640x480" ]; then 
> possible bashism in ./usr/share/freevo/contrib/fbcon/mgafb line 98 (should
> be 'b = a'):
> elif [ "$2" == "768x576" ]; then 
> possible bashism in ./usr/share/freevo/contrib/fbcon/mgafb line 100 (should
> be 'b = a'): 
> elif [ "$2" == "800x600" ]; then 

Not using bash (or a Debian Policy conformant shell interpreter which does 
provide such an extra feature) as /bin/sh is likely to lead to errors or 
unexpected behaviours.
Please be aware that although bash is currently the default /bin/sh there's a 
release goal for Lenny to make dash the default /bin/sh[1].

If you want more information about dash as /bin/sh, you can read:
http://lists.debian.org/debian-release/2008/01/msg00189.html

For more information please refer to the Debian Policy section 10.4 supporting 
this argument at:
http://www.debian.org/doc/debian-policy/ch-files.html#s-scripts

Hints about how to fix bashisms:
Sometimes these bugs are already fixed in Ubuntu, look at the PTS.
If not already fixed you can read:
https://wiki.ubuntu.com/DashAsBinSh

[1]http://release.debian.org/lenny/goals.txt

Thank you,
-- 
Atomo64 - Raphael

Please avoid sending me Word, PowerPoint or Excel attachments.
See http://www.gnu.org/philosophy/no-word-attachments.html