[pkg-fso-commits] [SCM] Automatic Display Manager branch, pamhelper, updated. debian/0.1-28-g232eb01

Enrico Zini enrico at enricozini.org
Fri Feb 20 11:13:51 UTC 2009


The following commit has been merged in the pamhelper branch:
commit 232eb01892695cb5cac907fc2faddde1bb75349b
Author: Enrico Zini <enrico at enricozini.org>
Date:   Fri Feb 20 11:12:56 2009 +0000

    Do not clean up the environment
    
    We already enforce to be run by root, so we can assume that the
    environment is not dirty.  Also, the previous path sanitisation was
    harmful, creating root sessions without sbin in the path.

diff --git a/TODO b/TODO
index 11bafac..4b29598 100644
--- a/TODO
+++ b/TODO
@@ -4,6 +4,7 @@
    and have something more meaningful instead like "0, 0, 30, 30, 60, 60"
  + log when the session is restarted
  + configure via preseeding
+ + path is not good for root
  - split X options before passing them to xinit?  Is it needed or xinit does it?
 
 Preseed values for testing:
diff --git a/nodm.c b/nodm.c
index d600074..82c02d3 100644
--- a/nodm.c
+++ b/nodm.c
@@ -440,8 +440,6 @@ int main (int argc, char **argv)
 	signal (SIGINT, SIG_DFL);
 	signal (SIGQUIT, SIG_DFL);
 
-	setenv ("PATH", "/bin:/usr/bin", 1);
-
 	/* save SU information */
 	syslog (LOG_INFO, "Successful su for %s by %s", name, "root");
 

-- 
Automatic Display Manager



More information about the pkg-fso-commits mailing list