[pkg-fso-commits] [SCM] FSO frameworkd Debian packaging branch, master, updated. milestone5.1

[Michael 'Mickey' Lauer]

The following commit has been merged in the master branch:
commit 010c15361861f174a6ae7b43f956cf4f804c0e84
Author: Michael 'Mickey' Lauer <mickey at vanille-media.de>
Date:   Thu Feb 12 02:40:21 2009 +0100

    start document for 'lessons learned' to guide us for version 2.x

diff --git a/docs/ogsmd/lessons b/docs/ogsmd/lessons
new file mode 100644
index 0000000..e4a6062
--- /dev/null
+++ b/docs/ogsmd/lessons
@@ -0,0 +1,33 @@
+Lessons learned from the implementation of ogsmd 1.x
+====================================================
+
+=== Things to keep ===
+
+... to be added ...
+
+=== Things to change ===
+
+* Per-command timeouts do not make sense; rather maintain a reasonable
+  channel timeout (say 90 seconds or so) that gets reset on every incoming
+  data. When we are actually waiting for an answer and it triggers,
+  try to escalate resetting the parser and/or (transparently) relaunching
+  the last command.
+  
+* Per-command retries _might_ make sense.
+
+* Dragging an error callback around for every command does not make
+  sense, if the error refers to channel errors (such as a timeout),
+  as opposed to an actual command response error (which makes sense).
+  
+* If there's no reliable way to detect unsolicited responses (such as
+  a physical or a virtual RING line) _and_ the modem does not
+  guarantee delaying them between a request and a response, then
+  the low level parser needs to be fed a list of valid prefixes for
+  every command.
+  
+* It _might_ make sense to define every AT command as a struct, including:
+  * a list of valid prefixes,
+  * a regular expression that groups values into elements,
+  * a mapping of values to types.
+  This could reduce quite some boilerplate code.
+

-- 
FSO frameworkd Debian packaging