[pkg-fso-maint] openmoko-panel-plugin and notifications

[Christian Adams]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

hi luca,

> While I am not an expert programmer, now that I looked at it I do not
> understand why updateGSMNetworkStatus [1] acts differently from
> updatePowerState [2] and updateCharge [3].  For the sake of code
> consistency, I would change that to the following, successfully  
> tested:
>
> --8<---------------cut here---------------start------------->8---
> diff --git a/openmoko-panel-plugin b/openmoko-panel-plugin
> index 4493e31..ecdf73e 100755
> --- a/openmoko-panel-plugin
> +++ b/openmoko-panel-plugin
> @@ -565,7 +565,7 @@ class GSMIcon( PowerStateIcon ):
>                  self.gsmCid = self.gsmStatus[u'cid']
>                  sendNofication = True
>
> -        if (sendNofication):
> +        if notificationAvailable:
>              self.gsmStatusChanged = True
>              self.sendNotification()
>
> --8<---------------cut here---------------end--------------->8---
>
> Thx, bye,
> Gismo / Luca
>
> Footnotes:
> [1] http://git.debian.org/?p=pkg-fso/openmoko-panel- 
> plugin.git;a=blob;f=openmoko-panel- 
> plugin;h=4493e31a4624768dbf3fdf823e9b0d79775c161e;hb=HEAD#l535
> [2] http://git.debian.org/?p=pkg-fso/openmoko-panel- 
> plugin.git;a=blob;f=openmoko-panel- 
> plugin;h=4493e31a4624768dbf3fdf823e9b0d79775c161e;hb=HEAD#l463
> [3] http://git.debian.org/?p=pkg-fso/openmoko-panel- 
> plugin.git;a=blob;f=openmoko-panel- 
> plugin;h=4493e31a4624768dbf3fdf823e9b0d79775c161e;hb=HEAD#l781

what you propose does unfortunately not what i had in mind what  
should happen there when i worte the code ..

the var sendNofication is defined only a few lines above and  
determins if we send out a notification at all so the line:

	if (sendNotification):

is essential there ..

ciao,
	christian (morlac) adams

- --
- -----BEGIN CONTACT BLOCK-----
   eMail:	morlac at morlac.de
   Jabber:	morlac at skavaer.homelinux.org
- ------END CONTACT BLOCK------

- -----BEGIN GEEK CODE BLOCK-----
Version: 3.1
GCS$/IT;d-;s:;a?;C++(+++)>++++;UL++++;P++(+++)>++++;
L++(+++);E---;W++;N(+);o?;K?;!w;!O;!M+>;!V;PS(+);PE;
Y+;PGP++;t+(++);5(+)>++;X(+);R*;tv->+;b++(+++);DI++;
D++(+++)>++++;G(+)>++;e+>+++;h-()>++;r++;y++;
- ------END GEEK CODE BLOCK------

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.7 (Darwin)

iD8DBQFJEeIWr81gVylJyzERAhzyAKDBOfkDwX9epzGyvkcn3p/l2c5bhQCfUsV4
mc05o67IfQ+7vobQ8KqLqqM=
=+vB1
-----END PGP SIGNATURE-----