[pkg-fso-maint] openmoko-panel-plugin and notifications

[Joachim Breitner]

Hi,

Am Mittwoch, den 05.11.2008, 23:49 +0100 schrieb Luca Capello:
> On Wed, 05 Nov 2008 18:03:32 +0100, Joachim Breitner wrote:
> > Am Mittwoch, den 05.11.2008, 13:51 +0100 schrieb Christian Adams:
> >> but it should be on line 570:
> >> 
> >> - -        if (sendNofication):
> >> - -            self.gsmStatusChanged = True
> >> - -            self.sendNotification()
> >> +        if (sendNofication):
> >> +            if (notificationAvailable):
> >> +                self.gsmStatusChanged = True
> >> +                self.sendNotification()
> >> 
> >> in our repo at projects.openmoko.org this error i made is fixed ..
> >
> > I have uploaded this fix, thanks.
> 
> Unfortunately, this is not enought, since python-notify is still a
> dependency [1].
> 
> I know I could fix this by myself, but I am already late with other
> planned work, sorry.

I was under the impression that
36     pynotify.init("panel-plugin")
will throw an exception if no notification daemon is present, and thus 
38 except:
39     notificationAvailable = False
will happen. I can’t check it right now, though.

If not, a proper check would be either to use get_server_info() as
in /usr/share/doc/python-notify/examples/test-server-info.py or to just
send all notifications and ignore all DBus errors in sendNotification().

Greetings,
Joachim


-- 
Joachim "nomeata" Breitner
Debian Developer
  nomeata at debian.org | ICQ# 74513189 | GPG-Keyid: 4743206C
  JID: nomeata at joachim-breitner.de | http://people.debian.org/~nomeata
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: Dies ist ein digital signierter Nachrichtenteil
Url : http://lists.alioth.debian.org/pipermail/pkg-fso-maint/attachments/20081106/b85f6f17/attachment.pgp