[pkg-fso-maint] install.sh: partition Re: [Fwd: patches against install.sh]

[Luca Capello]

Hi there!

On Wed, 04 Feb 2009 01:19:01 +0100, Luca Capello wrote:
> I cc:ed Karl, AFAIK he is not subscribed to the list.

Done again :-)

> On Tue, 13 Jan 2009 16:24:42 +0100, Joachim Breitner wrote:
>> From: "Karl Goetz" <karl at kgoetz.id.au>
> [...]
>> install.sh-partitioningbug-unmountbug.diff
>> - Replace broken while() in partitioning section with an if+while
>
> IMHO the new solution if+while is wrong [1]:

And indeed on a Om2008.12 plain image [2] it fails:
=====
root at om-gta02:~# ./install.sh partition
Running stage partition
Starting to partition the microSD card
[...]

Calling ioctl() to re-read partition table
 * Waiting for partitions to appear
E: Partitioning has failed, partitions have not been created
Command exited with non-zero status 1

root at om-gta02:~# dmesg
[...]
Only GTA01 hardware supported by ASoc driver
usb0: no IPv6 routers present
 mmcblk0: p1 p2
FAT: bogus number of reserved sectors
VFS: Can't find a valid FAT filesystem on dev mmcblk0p1.
FAT: bogus number of reserved sectors
VFS: Can't find a valid FAT filesystem on dev mmcblk0p1.
FAT: bogus number of reserved sectors
VFS: Can't find a valid FAT filesystem on dev mmcblk0p2.
FAT: bogus number of reserved sectors
VFS: Can't find a valid FAT filesystem on dev mmcblk0p2.
FAT: bogus number of reserved sectors
VFS: Can't find a valid FAT filesystem on dev mmcblk0p1.
FAT: bogus number of reserved sectors
VFS: Can't find a valid FAT filesystem on dev mmcblk0p1.
modem wakeup interrupt
root at om-gta02:~#
=====

Strangely enough, this does not fail on a FSO-MS5 image ("DEBUG: " lines
added to check the while loop):
=====
root at om-gta02:~# ./install.sh partition
Starting to partition the microSD card
[...]

Calling ioctl() to re-read partition table
 * Waiting for partitions to appear
DEBUG: two partitions
DEBUG: before while
DEBUG: after while
 * Partition table created
I: Done with stage partition
root at om-gta02:~#
=====

Does anyone know why?

> We test for the presence of the device(s), while we should do the
> opposite:

I anyway applied my previous patch [3], because it solved the issue for
Om2008.12 and it works as expected on FSO-MS3:
=====
root at om-gta02:~# ./install.sh partition
Starting to partition the microSD card
[...]

Calling ioctl() to re-read partition table
 * Waiting for partitions to appear
DEBUG: two partitions
DEBUG: before while
DEBUG: sleep_seconds = 3
DEBUG: after while
 * Partition table created
I: Done with stage partition
root at om-gta02:~#
=====

Thx, bye,
Gismo / Luca

> Footnotes: 
> [1] http://git.debian.org/?p=pkg-fso/files.git;a=commitdiff;h=d55f309cd6a94e77b00d86621091b2ef842e333e
[2] http://wiki.openmoko.org/wiki/Om_2008.12_Update
[3] http://git.debian.org/?p=pkg-fso/files.git;a=commitdiff;h=c12461b73f93afd59acfcf82e5ec3bb3bf298eab
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 314 bytes
Desc: not available
Url : http://lists.alioth.debian.org/pipermail/pkg-fso-maint/attachments/20090204/a84e9e9b/attachment.pgp