[pkg-fso-maint] [patch] install.sh update swap partition, options for interactivity

Steffen Moeller steffen_moeller at gmx.de
Fri Feb 13 16:05:18 UTC 2009

This works on the basis of the previously sent patch 0004, at least for me.

0005 - get swap partitions going, specify the SD_SWAP_SIZE env variable with a value > 0
0006 - adding --swap-size option with a numerical value that is interpreted as megabytes
and some other options for testing purposes. seems to work. What was before a big case
statement has now become a series of independent functions. The script no longer calls
itself but decides to call which functions. With vfat as the first partition, I no longer
mount it to /boot by default since the kernel cannot be installed with dpkg anyway.

The patch 0006 became too large. I apologize for it. The changes are dumb, so I feel
rather save, but there are plenty. In my view, the script profits considerably from the
now avoided recursion. To help the readability of the patch, I have not indented the code
in the functions. I'd ask for Luca or Joachim to do proceed with it, once they had a
change to review what I have done ... hoping for the patch to be accepted in the first place.

I am attaching the two patches and the script as a whole, I hope you don't mind.


Steffen (who could not be reached on his mobile today)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0005-Placing-swap-partition-last-calculating-cylinders.patch
Type: text/x-diff
Size: 3161 bytes
Desc: not available
Url : http://lists.alioth.debian.org/pipermail/pkg-fso-maint/attachments/20090213/248d1862/attachment-0002.patch 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0006-Allowing-options-to-override-settings-of-environment.patch
Type: text/x-diff
Size: 21849 bytes
Desc: not available
Url : http://lists.alioth.debian.org/pipermail/pkg-fso-maint/attachments/20090213/248d1862/attachment-0003.patch 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: install.sh
Type: application/x-sh
Size: 29804 bytes
Desc: not available
Url : http://lists.alioth.debian.org/pipermail/pkg-fso-maint/attachments/20090213/248d1862/attachment-0001.sh 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 260 bytes
Desc: OpenPGP digital signature
Url : http://lists.alioth.debian.org/pipermail/pkg-fso-maint/attachments/20090213/248d1862/attachment-0001.pgp 

More information about the pkg-fso-maint mailing list