[pkg-fso-maint] [PATCH] install.sh: add support for vfat on the /boot partition (was Re: install.sh - 4 proposals for patches)

[Joachim Breitner]

Hi,

Am Mittwoch, den 18.02.2009, 15:39 +0100 schrieb Steffen Moeller:
> > On Fri, 13 Feb 2009 02:47:31 +0100, Steffen Moeller wrote:
> >> -Thus, you should continue at your own risk.
> >> +Thus, you should continue at your own risk. You can still use Debian's
> >> +kernel for the OpenMoko, just don't mount your vfat boot partition to /boot
> >> +yet. Install the regular kernel package, then manually copy /boot/uImage.bin
> >         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> > This is not possible if /boot is on vfat
> 
> only if the vfat is already mounted to /boot at the time that dpkg is executed.
> I suggest not to mount and instead to copy over manually afterwards. My main concern is
> that the regular user should not be demotivated of using vfat. Otherwise, the qtopia would
> stop working and at least I am myself not prepared to victimise that for the moment. The
> message as it is put for the moment seems likely to be a hurdle for newbies.
> 
> >   http://lists.linuxtogo.org/pipermail/smartphones-userland/2008-November/000456.html



> --8<---------------cut here---------------start------------->8---
> chroot $INST_DIR /bin/sh -e <<__END_CHROOT__
> apt-get --yes install linux-image-2.6.28-openmoko-gta02
> apt-get clean
> __END_CHROOT__
> 
> if [ "$SD_PART1_FS" = "vfat" ]; then
> 	echo "Copying over the kernel to the vfat boot partition."
> 	BOOTDIR=""
> 	NEWLYMOUNTED=""
> 	if mount|cut -f1 -d\  | grep -q "/dev/mm*p0"; then
> 		BOOTDIR=$(mount| grep "^/dev/mm*p0"|cut -f3 -d\  )	
> 	else
> 		BOOTDIR="/tmp/bootdir_for_process_$$"
> 		if [ -d "$BOOTDIR" ]; then	
> 			echo "Found directory '$BOOTDIR' to already exist. This should not  happen."
> 			exit 1
> 		fi
> 		mkdir "$BOOTDIR"
> 	
> 		mount /dev/mm*p0 "$BOOTDIR"
> 		NEWLYMOUNTED="true"
> 	if
> 
> 	cp $INST_DIR/boot/uImage.bin $BOOTDIR
> 	
> 	if [ "true" = "$NEWLYMOUNTED" ]; then
> 		umount "$BOOTDIR"
> 		rmdir "$BOOTDIR"
> 	fi
> 	
> fi
> --8<---------------cut here---------------end--------------->8---

I would suggest to simplify it: Add the first partition to fstab,
pointing to /boot-vfat instead of /boot. Then add an 
> rsync --copy-links --archive --recursive --delete /boot/ /boot-vfat/
or
> rsync -Lar --delete /boot/ /boot-vfat/
at the appropriate point, and tell the user to run this command after a
kernel package upgrade. Seems to be simpler and more reliable than
having mount/unmount commands at unusual places.

Greetings,
Joachim
-- 
Joachim "nomeata" Breitner
Debian Developer
  nomeata at debian.org | ICQ# 74513189 | GPG-Keyid: 4743206C
  JID: nomeata at joachim-breitner.de | http://people.debian.org/~nomeata
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: Dies ist ein digital signierter Nachrichtenteil
Url : http://lists.alioth.debian.org/pipermail/pkg-fso-maint/attachments/20090218/4de8127a/attachment.pgp