[pkg-fso-maint] [PATCH] install.sh: add $SD_PART1_SIZE and $SD_SWAP_SIZE user variables (was Re: install.sh - 4 proposals for patches)

[Steffen Moeller]

Hi Luca,

Luca Capello wrote:

> Finally, the last patch for today :-D

I am reading my mails backwards ... it is my first for the moment :)

> On Fri, 13 Feb 2009 02:47:31 +0100, Steffen Moeller wrote:
>>> >From 6834aca5e0a66ab795daae472356ccc3c2b5edae Mon Sep 17 00:00:00 2001
>> From: Steffen Moeller <steffen_moeller at gmx.de>
>> Date: Fri, 13 Feb 2009 02:38:37 +0100
>> Subject: [PATCH] Added formatting of vfat systems, prepared swap partition.
> 
> These two issues are completely different: you should provide a first
> patch for $SD_PART1_SIZE, then a second one for $SD_SWAP +
> $SD_SWAP_SIZE.  However, my concerns...
> 
> 
> 1) why would one like a bigger /boot partition?
> 
>    * please always think about the ordinary user, i.e. someone who
>      installs Debian on the Openmoko without being an expert GNU/Linux
>      user

It is because the first partition is also /media/card in Qtopia and a series of
applications share it with the booting for Debian. The phone number database goes there,
or the OpenStreetMap data, or ...

>    * there is no automatic way to switch between various U-Boot kernel
>      images (the reason for a bigger /boot partition), thus if you know
>      how to deal with symlinks and know what you are doing, then you
>      also know how to manually create a bigger /boot partition since the
>      beginning (this is why install.sh is separated into self-contained
>      stages)

With vfat there is no symlinks, so one would rename to uImage.bin whataver shall be used.
I would now for instance copy the 2.6.24 version next to the installed 2.6.28 one and
start comparing the two more.

> 2) why do you need a swap partition?  I have not followed the discussion
>    on this matter, so providing link to constructive threads is enough
> 
>>  # run partitioner
>> -if [ "$SD_PART1_FS" = "vfat" ]; then
>> +rootpartno=2
>> +bootfstypeno=83
> 
> Please, use uppercase variables.

They are intentionally lowercase since they are of internal use only.

>> +if [ "vfat" = "$SD_PART1_FS" ]; then
> 
> Semantically, this test (and some following ones) order is wrong.

I did not know how to change a patch afterwards. I wished you would decide over that
functionality by looking at the latest version. I had added some logics to allow the swap
partition to be the last partition of the device.

> 
>> +	bootfstypeno=4
> [...]
>> +EOBOOTCONF
> [...]
>> +EOSWAPCONF
> [...]
>> +EOROOTCONF
> 
> Are telling me that reading this shell script is linear?  ;-)

Er, yes.

>> +	if fdisk $SD_DEVICE < /tmp/argsToFdisk$$; then
>> +		echo "Partitioning was successful."
>> +		#rm /tmp/argsToFdisk$$
>> +	else
>> +		echo "Partitioning failed, could not execute with fdisk:"
>> +		cat /tmp/argsToFdisk$$
>> +		exit -1
>> +	fi
> 
> I am not sure if this is clearer: I would prefer the previous way of
> partitioning, because it is easier to repeat manually (you just follow
> the order the commands are given).

If something went wrong, then cat `ls -lt /tmp/argsToFdisk*|head -1` will print the
commands sent to fdisk.

>>  echo " * Installing /root/.xsession"
>> -case $WINDOW_MANAGER in
>> -fbpanel) 
> [...]
>> +EOZHONE
>> +
>> +fi
> 
> This part has nothing to do with partitioning and should go into a
> separate patch.

The -fbpanel bits - right.

Steffen