[pkg-fso-maint] Bug#538797: nodm: breaks when NODM_X_OPTIONS includes a display number or vtN

[Joachim Breitner]

Hi,

Am Dienstag, den 28.07.2009, 00:35 -0700 schrieb Vagrant Cascadian:
> On Mon, Jul 27, 2009 at 10:11:12PM +0200, Joachim Breitner wrote:
> > Am Montag, den 27.07.2009, 00:10 -0700 schrieb Vagrant Cascadian:
> > > if NODM_X_OPTIONS includes vtN or a display, nodm still passes both to the
> > > xinit commandline. it should probably parse NODM_X_OPTIONS and only add missing
> > > entries.
> > 
> > this is reasonable. Can you provide a patch?
> 
> parsing NODM_X_OPTIONS in C is a bit over my head.

Ok, no problem.

> a slightly different approach... this simple patch works around the problem by
> simply appending vtN at the end, though has the disadvantage of overriding vt
> if specified in NODM_X_OPTIONS, but at least it allows to specify the DISPLAY,
> which needs to be the first argument.
> 
> --- nodm-0.6.orig/nodm.c
> +++ nodm-0.6/nodm.c
> @@ -582,7 +582,7 @@
>         if (xoptions[0] == 0)
>                 snprintf(xoptions1, BUFSIZ, "vt%d", vt_num);
>         else
> -               snprintf(xoptions1, BUFSIZ, "vt%d %s", vt_num, xoptions);
> +               snprintf(xoptions1, BUFSIZ, "%s vt%d", xoptions, vt_num);
> 
>         setenv("NODM_RUN_SESSION", "1", 1);
>         run_and_restart(xinit, opt_session, xoptions1, mst);
> 
> though really, optionally having a way so that nodm doesn't add vtN at all
> would be fairly simple, and would still allow for it to be specified through
> NODM_X_OPTIONS.

How about allowing NODM_FIRST_VT to be empty, do disable the
auto-detection and auto option adding completely? Would that suit your
needs?

Greetings,
Joachim

-- 
Joachim "nomeata" Breitner
Debian Developer
  nomeata at debian.org | ICQ# 74513189 | GPG-Keyid: 4743206C
  JID: nomeata at joachim-breitner.de | http://people.debian.org/~nomeata
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: Dies ist ein digital signierter Nachrichtenteil
URL: <http://lists.alioth.debian.org/pipermail/pkg-fso-maint/attachments/20090728/003500de/attachment.pgp>