[pkg-fso-maint] some issues in install.sh

[Brian DeRocher]

Hi,

I just ran (by hand) the debian install.sh script for OpenMoko and thought i 
share some findings.  I used version 3.0.

You can give the part1_fs option, but line 724 will do ext2 even if ext3 was 
specified.
	mkfs.ext2 ${SD_DEVICE}p1


This code:

	if [ "$SINGLE_PART" = "true" ]; then
		mkfs.ext2 ${SD_DEVICE}p1
		if [ 0 -lt "$SD_SWAP_SIZE" ]; then
			echo " * Formatting swap on ${SD_DEVICE}p2"
			mkswap ${SD_DEVICE}p2
		fi
	else
		mkfs.$SD_PART1_FS ${SD_DEVICE}p1
		mkfs.$SD_PART2_FS ${SD_DEVICE}p2
		if [ 0 -lt "$SD_SWAP_SIZE" ]; then
			echo " * Formatting swap on ${SD_DEVICE}p3"
			mkswap ${SD_DEVICE}p3
		fi
	fi

should be re-factored to something like this to help avoid those bugs.

	mkfs.$SD_PART1_FS ${SD_DEVICE}p1
	nextpart=2
	if [ "$SINGLE_PART" != "true" ]; then
		mkfs.$SD_PART2_FS ${SD_DEVICE}p2
		nextpart=3
	fi
	if [ 0 -lt "$SD_SWAP_SIZE" ]; then
		echo " * Formatting swap on ${SD_DEVICE}p${nextpart}"
		mkswap ${SD_DEVICE}p${nextpart}
	fi


Likewise, line 695 can be re-factored, no bug there though.

rootpartno is declared, but it's never used.  line 604

EXTRA_TASKS is declared, but never used.

Personally, i wouldn't give the user the option to have vfat file systems.  
Similarly, i suggest to drop u-boot.

I don't see what calls action_all().  Not even line 1,496 will call it.  Also 
it won't do action_tasks() or action_cleanup().

Usage for "all" should say that tasks come after configuration.

MOUNT_PROC could use some explanation.  Which packages need it.  Is there any 
harm in just mounting proc?

thanks,
Brian